Thanks a lot Peter! I will make corrections suggested and issue a pull request! Will see this one through all the way till infinispan-cdi hooks into spi api we made!
Cheers On 12-01-04 11:44 AM, Pete Muir wrote: > Done, comments on the commit, sorry for the delay! > > On 28 Dec 2011, at 16:23, Vladimir Blagojevic wrote: > >> Pete, >> >> Would you have a quick look at >> https://github.com/vblagoje/infinispan/compare/master...t_1636_m as I >> think this is what needs to be done! Still a bit rough phase but I would >> like to check with you before proceeding further! >> >> Regards, >> Vladimir >> >> On 11-12-23 12:18 PM, Pete Muir wrote: >>> Yep. This is what CDI calls an "injection target" (an object which is the >>> target for injection). So, what i would suggest you do is add an SPI to the >>> map/reduce code that has callbacks which can be hooked into at the >>> appropriate point by CDI or something else. So you would want a callback >>> for inject(), postConstruct() and preDestroy(). You would provide a default >>> impl for plain old java, which were basically no-ops, and then use e.g. the >>> service loader to load other implementations, and call back to them. You >>> then call this SPI at the relevant points in your code. >>> >>> Does that make any more sense? >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev