The javadoc for @AroundInvoke says this:
Defines an interceptor method. The method must have the signature:
* public Object <METHOD>(InvocationContext) throws Exception
Previously, only the method's return type and parameter types were
checked and a warning was logged (the code did not check if the method
throws Exception or anything else). Instead of logging the warning, the
code now throws DefinitionException (see
https://issues.jboss.org/browse/WELD-580) and also checks if the method
throws exactly Exception.
Marko
On 26.3.2012 20:44, Ales Justin wrote:
What does the spec say about interceptor method signature?
We can be more lenient, and just issue a warning.
But i think we had that before. Marko?
-Ales
On Mar 26, 2012, at 18:56, Pete Muir<[email protected]> wrote:
Wrong thread, but +1 for 3.1.1
On 26 Mar 2012, at 17:55, Jason Porter wrote:
On Mon 26 Mar 2012 10:53:14 AM MDT, Pete Muir wrote:
I think some TCK checks this somewhere :-(
On 26 Mar 2012, at 17:48, Jason Porter wrote:
This one is actually pretty interesting. I have declared that it throws
Throwable instead of Exception, which is correct according to the
compiler, but it looks like according to the spec, we need it to be
exact. This is actually, *very easy* to fix :) but I am surprised it
doesn't work according to the way Weld is handling it.
On Mon 26 Mar 2012 10:46:24 AM MDT, Pete Muir wrote:
Or about the specific issue?
On 26 Mar 2012, at 17:44, Jason Porter wrote:
We were only planning on doing a very small release with new examples,
documentation improvements and minor bug fixes, but we don't have a
date yet. The majority of our development time is going toward
DeltaSpike
On Thu 22 Mar 2012 10:04:03 AM MDT, Pete Muir wrote:
No, sorry.
Jason P, any idea?
On 22 Mar 2012, at 16:01, Galder Zamarreño wrote:
We're already using the latest which is 3.1.0.Final:
https://repository.jboss.org/nexus/content/groups/public/org/jboss/solder/solder-impl/
https://github.com/galderz/infinispan/blob/master/parent/pom.xml#L167
Any idea when the next solder version is out?
On Mar 22, 2012, at 1:35 PM, Pete Muir wrote:
This is a bug in Solder. I would try updating to the latest version of Solder.
On 22 Mar 2012, at 08:49, Galder Zamarreño wrote:
Hi,
I've been having a bit of "fun" deploying Infinispan AS7 quickstarts in domain
mode.
1. Trying to deploy Infinispan AS7 domain quickstart
(https://github.com/galderz/infinispan-quickstart/tree/t_710final/jboss-as7)
into AS 7.1.0.Final fails with:
https://issues.jboss.org/browse/AS7-4048
2. This appears to be fixed in AS 7.1.1.Final but in this version, there's
another error when you deploy the quickstart via the CLI:
[Server:server-four] 08:53:47,370 INFO [org.jboss.as.server]
(host-controller-connection-threads - 1) JBAS015870: Deploy of deployment
"infinispan-jboss-as7.war" was rolled back with failure message JBAS014750:
Operation handler failed to complete
I asked Emanuel about this and he's told me that this is fixed in master (??).
3. Right, so let's have a go at deploying the quickstart in master domain mode.
Doesn't work:
[Server:server-three] 09:26:02,823 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-6)
MSC00001: Failed to start service
jboss.deployment.unit."infinispan-jboss-as7.war".WeldService:
org.jboss.msc.service.StartException in service
jboss.deployment.unit."infinispan-jboss-as7.war".WeldService:
org.jboss.weld.exceptions.DefinitionException: WELD-001450 Interceptor method public
java.lang.Object
org.jboss.solder.exception.control.ExceptionHandledInterceptor.passExceptionsToSolderCatch(javax.interceptor.InvocationContext)
throws java.lang.Throwable does not declare that it throws Exception.
[Server:server-three] at
org.jboss.as.weld.services.WeldService.start(WeldService.java:83)
[Server:server-three] at
org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811)
[jboss-msc-1.0.2.GA.jar:1.0.2.GA]
[Server:server-three] at
org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746)
[jboss-msc-1.0.2.GA.jar:1.0.2.GA]
[Server:server-three] at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[classes.jar:1.6.0_29]
[Server:server-three] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[classes.jar:1.6.0_29]
[Server:server-three] at java.lang.Thread.run(Thread.java:680)
[classes.jar:1.6.0_29]
[Server:server-three] Caused by: org.jboss.weld.exceptions.DefinitionException:
WELD-001450 Interceptor method public java.lang.Object
org.jboss.solder.exception.control.ExceptionHandledInterceptor.passExceptionsToSolderCatch(javax.interceptor.InvocationContext)
throws java.lang.Throwable does not declare that it throws Exception.
[Server:server-three] at
org.jboss.weld.interceptor.reader.InterceptorMetadataUtils.isValidBusinessMethodInterceptorMethod(InterceptorMetadataUtils.java:98)
[Server:server-three] at
org.jboss.weld.interceptor.reader.InterceptorMetadataUtils.isInterceptorMethod(InterceptorMetadataUtils.java:53)
[Server:server-three] at
org.jboss.weld.interceptor.reader.InterceptorMetadataUtils.buildMethodMap(InterceptorMetadataUtils.java:130)
[Server:server-three] at
org.jboss.weld.interceptor.reader.InterceptorMetadataUtils.readMetadataForInterceptorClass(InterceptorMetadataUtils.java:38)
[Server:server-three] at
org.jboss.weld.interceptor.reader.cache.DefaultMetadataCachingReader$1.apply(DefaultMetadataCachingReader.java:30)
[Server:server-three] at
org.jboss.weld.interceptor.reader.cache.DefaultMetadataCachingReader$1.apply(DefaultMetadataCachingReader.java:28)
[Server:server-three] at
com.google.common.collect.ComputingConcurrentHashMap$ComputingValueReference.compute(ComputingConcurrentHashMap.java:355)
[Server:server-three] at
com.google.common.collect.ComputingConcurrentHashMap$ComputingSegment.compute(ComputingConcurrentHashMap.java:184)
[Server:server-three] at
com.google.common.collect.ComputingConcurrentHashMap$ComputingSegment.getOrCompute(ComputingConcurrentHashMap.java:153)
[Server:server-three] at
com.google.common.collect.ComputingConcurrentHashMap.getOrCompute(ComputingConcurrentHashMap.java:69)
[Server:server-three] at
com.google.common.collect.ComputingConcurrentHashMap$ComputingMapAdapter.get(ComputingConcurrentHashMap.java:393)
[Server:server-three] at
org.jboss.weld.interceptor.reader.cache.DefaultMetadataCachingReader.getInterceptorMetadata(DefaultMetadataCachingReader.java:54)
[Server:server-three] at
org.jboss.weld.bean.InterceptorImpl.<init>(InterceptorImpl.java:64)
[Server:server-three] at
org.jboss.weld.bean.InterceptorImpl.of(InterceptorImpl.java:59)
[Server:server-three] at
org.jboss.weld.bootstrap.AbstractBeanDeployer.createInterceptor(AbstractBeanDeployer.java:228)
[Server:server-three] at
org.jboss.weld.bootstrap.BeanDeployer.createBeans(BeanDeployer.java:137)
[Server:server-three] at
org.jboss.weld.bootstrap.BeanDeployment.createBeans(BeanDeployment.java:204)
[Server:server-three] at
org.jboss.weld.bootstrap.WeldBootstrap.deployBeans(WeldBootstrap.java:349)
[Server:server-three] at
org.jboss.as.weld.WeldContainer.start(WeldContainer.java:82)
[Server:server-three] at
org.jboss.as.weld.services.WeldService.start(WeldService.java:76)
[Server:server-three] ... 5 more
Kevin/Pete, any idea what's up this time?
Please, let's try to get this fixed before 7.1.2.Final is out so that we can
finally have the Infinispan quickstarts working again.
Cheers,
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache
--
Member of JBoss Seam Team
Author of Seam Catch
--
Member of JBoss Seam Team
Author of Seam Catch
Boo. Alright then. I can get this fixed. On my TODO is to dicuss with
the community a date for Seam 3.1.1 or 3.2 whatever we call it (I'm
leaning more towards 3.1.1 though). Right now I'm thinking end of April
if things all fall on my sholders to fix and improve docs.
--
Member of JBoss Seam Team
Author of Seam Catch
_______________________________________________
jboss-as7-dev mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
_______________________________________________
infinispan-dev mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/infinispan-dev
