On 11 Oct 2012, at 16:38, Vladimir Blagojevic <[email protected]> wrote:
> On 12-10-11 7:45 AM, Manik Surtani wrote: >> >> On 1 Oct 2012, at 14:40, Vladimir Blagojevic <[email protected]> wrote: >> >>> Now that I am actually implementing this I am wondering why don't we simply >>> add getUUID to CacheRpcCommand. CancellationService will use this UUID for >>> command cancellation, some other services might need UUID for something >>> else. Introducing CancellableCommand does not add much except bunch of >>> instanceof constructs and explicitly connects UUID with >>> concept of command cancellation which might not been only valid use of >>> command UUID. >> >> No, this should be on CancellableCommand only. No sense in engineering for >> something we may not need and polluting interfaces. >> > Ok, no problem. I'll adjust the PR. However, I need to mark that only > CacheRpcCommand can be cancellable. So we make CancellableCommand extend > CacheRpcCommand? Sure. -- Manik Surtani [email protected] twitter.com/maniksurtani Platform Architect, JBoss Data Grid http://red.ht/data-grid
_______________________________________________ infinispan-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/infinispan-dev
