Good point, will change that. I've actually been experimenting with making a CheckStyle rule which will detect such violations, but there are so many that I won't send a pull with that :-) At some point when we'll have a more relaxed pace I'll send a checkstyle proposal to log warnings rather than fail the build, so we can then change them gradually.
Sanne On 4 October 2013 12:03, Dan Berindei <[email protected]> wrote: > +1 to apply it, but maybe we should use the occasion to move the error > message to the Log interface as well. > > > On Fri, Oct 4, 2013 at 2:43 AM, Sanne Grinovero <[email protected]> > wrote: >> >> Currently if a cache is configured with indexing enabled, but the >> Query module isn't on classpath, you get a simple warning. >> >> I think this should fail with a configuration validation error; it's >> not just safer but also consistent with many other validations. >> >> I've created ISPN-3583 and patch is ready.. any good reason to not apply >> it? >> >> Sanne >> _______________________________________________ >> infinispan-dev mailing list >> [email protected] >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > > > _______________________________________________ > infinispan-dev mailing list > [email protected] > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/infinispan-dev
