On Thu, Mar 13, 2014 at 11:14 AM, Vladimir Blagojevic <[email protected]> wrote: > Mircea and I wanted to "promote" AdvancedCacheLoader.KeyFilter or merge > it with one filter we all choose to use because we have so many of these > internal filter classes it is ridiculous. The filter you wrote is THE one?
I can't say that for sure. Basically the KeyFilter that exists in the notifications package was what I was going to use as it is more generic since the method is called accept, which I thought was better than shouldLoadKey. Are we thinking we would get rid of the KeyFilter and only use KeyValueFilter though ? - Will > > Vladimir > On 3/13/2014, 8:35 AM, William Burns wrote: >> On Thu, Mar 13, 2014 at 8:31 AM, Pedro Ruivo <[email protected]> wrote: >>> Hi, >>> >>> #1 and #2 are ok to me but, IMO, the filter package should be in commons >>> module >> Sorry I forgot to detail why I said core. I originally planned for >> commons package as well, however the KeyValueFilter class needs the >> Metadata class, which doesn't live in the commons package. I didn't >> want to separate the 2 filter classes. And unfortunately the Metadata >> class relies on other classes in core, so that isn't easy to move over >> either, but doable :( WDYT? >> >> > > _______________________________________________ > infinispan-dev mailing list > [email protected] > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/infinispan-dev
