On 06/19/2014 03:12 PM, Galder Zamarreño wrote: > Hi all, > > As I work on ISPN-3950, I’ve been thinking about the location of > KeyValueFilterFactory and ConverterFactory interfaces. These interfaces > provide filter/converter instances to be installed in server/hotrod, but we > expect users to provide implementations of such classes and plug the server > with them. > > These interfaces are currently in server/hotrod project, something I’m not > keen on doing any more, because users would need to get access to these > interfaces and they could start fiddling with other stuff in that module, and > I want to avoid that at all costs, particularly since I’m hoping to do some > major refactoring of the decoders in 7.1. > > So, the q is: where should KeyValueFilterFactory and ConverterFactory live? > > They’re for sure needed by server/hotrod. client/hotrod-client does not need > them explicitly, but the users need to provide implementations of them and > plug them to the server. With this in mind, core/ might be the best place for > it. They cannot live in commons/ cos it’d would require to move > KeyValueFilter/Converter and other dependant classes to commons. > IMO, this is the best solution. I don't think a user should bring all the core/ (and probably its dependencies) to implement a couple of interfaces...
Cheers, Pedro > Is everyone happy with ConverterFactory and KeyValueFilterFactory being in > core/? > > Cheers, > -- > Galder Zamarreño > gal...@redhat.com > twitter.com/galderz > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev
