BTW, these changes were added a bit late in the Infinispan 8.2 development so I had to keep them at the minimum, otherwise I would have added lazy search factory initialization already. But since we already have some strange random mystery deadlocks at server start (which do not seem related, until I'm proven wrong :)) I was reluctant to do it.
On 03/11/2016 04:02 PM, Adrian Nistor wrote: > The laziness could be tried first in Infinispan, then if it does not > work we might need some help from hibernate-search. That might save > hibernate-search from adding another hack for infinispan. > > Thanks! > > On 03/11/2016 03:13 PM, Sanne Grinovero wrote: >> On 11 March 2016 at 13:00, Adrian Nistor <anis...@redhat.com> wrote: >>> Hi Sanne, >>> >>> yes, but there is a small unsolved issue ATM and the implementation >>> needs more polishing before we get to Ispn 9.0; infinispan and probably >>> search too will need a bit more tweaking. >>> >>> Current approach is that the search factory is first created with 0 >>> classes and then after initialization of the cache and the index manager >>> has completed we reconfigure the search factory again, exactly once, and >>> all known indexed classes are added at once. We cannot add the indexed >>> classes at the initial creation time because that would cause infinispan >>> directory to try to create the needed caches (for locking, metadata,...) >>> while the user's cache has not even finished initializing. These leads >>> to deadlock in our component registry. This approach if far more >>> efficient and less error prone than the previous but still not ideal. >> Sounds like this would be solved by initializing the SearchIntegrator >> lazily (only once) ? >> >> Let us know what the Search team could do, it would be very nice for >> us to be able to >> drop this requirement as it makes any other change we're working on more >> complex >> to implement. >> >> Thanks! >> Sanne >> >>> Adrian >>> >>> On 03/11/2016 02:07 PM, Sanne Grinovero wrote: >>>> When booting Infinispan Server v. 8.2.0.Final I see this message being >>>> logged: >>>> >>>> ISPN000403: No indexable classes were defined for this indexed cache; >>>> switching to autodetection (support for autodetection will be removed >>>> in Infinispan 9.0). >>>> >>>> Does it mean we can finally remove the infamous, super-complex to >>>> maintain and generally hated "feature" in Hibernate Search to >>>> dynamically add new entities on the fly? >>>> _______________________________________________ >>>> infinispan-dev mailing list >>>> infinispan-dev@lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev
