+1 to add FRAG3 back in, with frag_size="200k" to make fragmentation less likely, yet stay under max_credits * min_threshold.
Dan On Wed, Feb 22, 2017 at 9:41 PM, Alan Field <afi...@redhat.com> wrote: > > > ----- Original Message ----- >> From: "Pedro Ruivo" <pe...@infinispan.org> >> To: "ispn-dev" <infinispan-dev@lists.jboss.org> >> Sent: Wednesday, February 22, 2017 9:59:21 AM >> Subject: [infinispan-dev] Default TCP configuration is broken. >> >> Hi team, >> >> The 'default-jgroups-tcp.xml" has MFC protocol without the FRAG2/3 >> protocol. This is broken when we send a multicast message larger than >> 'max-credits'. It will block forever in MFC [1]. No timeouts since we >> don't have the CompletableFuture at this point. >> >> Possible solutions are: >> >> #1 put back FRAG2/3 >> >> advantage: we have multicast flow control. >> disadvantage: all messages are fragmented (unicast and multicast), that >> probably requires more resources (more messages in NAKACK and UNICAST >> tables?) > > This is my preferred solution, since removing MFC did not work for me! > > Thanks, > Alan > >> >> #2 remove MFC >> >> advantage: probably low resources usages. TCP will handle any fragmentation. >> disadvantage: we don't have multicast flow control. >> >> #3 alternative? >> >> Cheers, >> Pedro >> >> [1] actually, I need a thread dump to confirm it. >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev
