You basically just said +1 to all the ones I want to remove :) Tristan
On 12/1/17 3:13 PM, Sebastian Laskawiec wrote: > Hey Tristan, > > Comments inlined. > > Thanks, > Sebastian > > On Fri, Dec 1, 2017 at 9:28 AM Tristan Tarrant <ttarr...@redhat.com > <mailto:ttarr...@redhat.com>> wrote: > > Hello people, > > I'd like to rationalize the PR labels because I believe some of them are > useless: > > [Ready for review] - Any PR without the [Preview] label must fall under > this category > > > If a PR doesn't fall into Preview category, it must be Ready for Review. > In my opinion "Ready for Review" is redundant. > > [Backport] - The burden should be on the PR owner to create relevant > backport PRs, not on the reviewer > > > +1 > > [Wait CI Results] - PRs should only be integrated after a successful CI > run (or when failures can be proven to be pre-existing) > > > All PRs should be evaluated by Jenkins. The CI check has 3 icons on > Github Pull Request page - green tick, red cross and yellow dot. Yellow > dot means that the PR is being built right now (or waiting in the > queue). I believe "Wait CI Results" and that yellow dot are identical > and "Wait CI Result" is redundant. > > [Check CI Failures!] - The CI runs already add failure/success to the PR > status. Checking CI failures should apply to ALL PRs. > [On Ice] PR should be closed and reopened when relevant again. > > > Let just close such PRs! Redundant... > > > Comments/suggestions ? > > Tristan > -- > Tristan Tarrant > Infinispan Lead > JBoss, a division of Red Hat > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org <mailto:infinispan-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/infinispan-dev > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev > -- Tristan Tarrant Infinispan Lead JBoss, a division of Red Hat _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev