Hi Johan,

> Hi all,
> 
> I made some little changes to the sources.
> (included is the new c-file and the patch against the tarred version)
> 
> * function who_am_i : changed the curr_user->pw_passwd to curr_user->pw_name
> * function find_anf_open_passwd :
>    -- option -d seemed not working, always overruled by $CVSROOT  (fixed it)
>    -- added check for :pserver: in $CVSROOT and exit if found. (this means the 
> passwd cannot been changed using the pserver method.
>    
> It seems to work with me when doing the folowing steps  :
> 
> * checkout the CVSROOT/passwd file
> * cvspasswd -d "PATH TO DIR WHERE CVSROOT IS EXTRACTED"
> * checkin the CVSROOT/passwd
> 
> Since we don't have direct access to the repository, this was the only way to do 
> it.  
> 
> Since root != cvs administator, I'm thinking of changing the root behaviour of 
> cvspasswd.  I know this is not secure at all, but for our sites non root users 
> should be able to add new users.  
> 
> I hope this helped a little, and thanks for the effort.
> 
> Johan
>    
> 

Thanks for the patch.  I have updated my sources and am including the
latest c file and a unified diff version of your patch.  I appreciate the
feedback, and am glad this is usefull to people.

As far as the root behaviour of not allowing to add new users, I could
really go either way with the cvspasswd utility.  It's really the permissions
on the actual passwd file that dictate who can change/update it and who cannot.
These permissions will always override what the utility will try and
let you do.  I guess I just wanted an extra check in the utility that
would keep you from doing something accidentally that you didn't want.

Let me know what you think,

Steven


-- 
==================================================================
== Steven M. Cherry                       [EMAIL PROTECTED]  ==
==                       http://216.59.115.58/steven/home.html  ==
==================================================================

cvspasswd.tar.gz

Reply via email to