On Sun, Nov 18, 2012 at 10:29:30AM +0200, Itamar Heim wrote: > On 11/18/2012 10:20 AM, Dan Kenigsberg wrote: > >On Sat, Nov 17, 2012 at 09:10:02PM +0200, Itamar Heim wrote: > >>On 11/17/2012 07:24 PM, Dan Kenigsberg wrote: > >>>On Tue, Nov 13, 2012 at 08:46:45AM +0200, Itamar Heim wrote: > >>>>On 11/12/2012 12:11 PM, Shahar Havivi wrote: > >>>>>>From: Doron Fediuck <[email protected]> > >>>>>>To: Itamar Heim <[email protected]> > >>>>>>Cc: Juan Antonio Hernandez Fernandez <[email protected]>, Vojtech > >>>>>>Szocs <[email protected]>, Einav Cohen <[email protected]>, > >>>>>>[email protected] > >>>>>>Sent: Wed, 07 Nov 2012 10:14:24 -0500 (EST) > >>>>>>Subject: Re: Sample UI plugins repository on gerrit.ovirt.org > >>>>>> > >>>>>>----- Original Message ----- > >>>>>>>From: "Itamar Heim" <[email protected]> > >>>>>>>To: "Michal Skrivanek" <[email protected]> > >>>>>>>Cc: "Juan Antonio Hernandez Fernandez" <[email protected]>, "Vojtech > >>>>>>>Szocs" <[email protected]>, "Einav Cohen" > >>>>>>><[email protected]>, [email protected] > >>>>>>>Sent: Wednesday, November 7, 2012 11:07:21 AM > >>>>>>>Subject: Re: Sample UI plugins repository on gerrit.ovirt.org > >>>>>>> > >>>>>>>On 11/07/2012 09:54 AM, Michal Skrivanek wrote: > >>>>>>>> > >>>>>>>>On Nov 7, 2012, at 09:45 , Itamar Heim wrote: > >>>>>>>> > >>>>>>>>>On 11/02/2012 07:04 PM, Vojtech Szocs wrote: > >>>>>>>>>>Hi guys, > >>>>>>>>>> > >>>>>>>>>>UI plugins is an upcoming oVirt feature that allows extending > >>>>>>>>>>oVirt Engine functionality through Web Admin application's user > >>>>>>>>>>interface. > >>>>>>>>>> > >>>>>>>>>>In addition to providing relevant documentation (wiki), I'd like > >>>>>>>>>>to establish a git repository for hosting sample UI plugins. > >>>>>>>>>>This will make it easier for others to get started with writing > >>>>>>>>>>custom plugins, as well as document plugin API on examples. > >>>>>>>>>> > >>>>>>>>>>What do you think about creating such repository on > >>>>>>>>>>gerrit.ovirt.org? (to be mirrored on github.com/oVirt) > >>>>>>>>>> > >>>>>>>>> > >>>>>>>>>didn't see any replies on this. > >>>>>>>>>+1 from me to host sample repos on ovirt gerrit. > >>>>>>>>> > >>>>>>>>>so if no nacks/comments, i'll add a samples-uiplugins repo to > >>>>>>>>>gerrit next week. > >>>>>>>>Is something similar planned for vdsm hooks as well? > >>>>>>> > >>>>>>>its an option, though it is managed today inside vdsm repo. > >>>>>>>we also have some samples of very basic user portal in java/python > >>>>>>>using > >>>>>>>the REST API i'd like to place in a samples-portals repo. > >>>>>Now that the ovirt engine support user level API, having a repository > >>>>>with > >>>>>Samples of user-portal like implementations can be also useful. > >>>>> > >>>>>Can you add this repository as well? > >>>>>> > >>>>>>So why not have a samples repo for everything? > >>>> > >>>> > >>>>i didn't hear any objections for both. > >>>>created repo's: > >>>>samples-uiplugins > >>>>samples-portals > >>>> > >>>>danken, there is an open question if vdsm hooks should move to such > >>>>a repo. i'm fine with "don't fix if it ain't broken", just know you > >>>>have the option. > >>> > >>>As you have probably guessed, I prefer keeping vdsm's hooks where they > >>>are - in vdsm's git tree. Hooks are (loosely) related to a vdsm version, > >>>btw. Come to think of this, Laszlo, I think we should drop the cpupin > >>>hook now that we have it as a fully-fledged vdsm feature. > >>> > >> > >>well, someone may want it with an earlier version of engine - maybe > >>rename them to .old? > >>btw, its true for directlun, fileinject, promisc and smartcard (3.2). > > > >I have no plans to remove the ovirt-3.1 branch. Whomever wants to use > >ovirt-3.1 for whatever reason, can take the obsoleted hooks from there. > > all historical links, wiki, etc, point to the master branch, and > these are samples, which someone may want to use for other close > things as well, so i'm not sure what is the incentive to remove such > samples?
If someone uses master branch's vdsm with deprecated hooks, he may obtain unexpected result. E.g., I do not expect that the promisc hook is going to work well if ovirt-3.2's portMirroring feature is used. Broken links should be fixed, broken code should be dropped. Dan. _______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
