ops, sorry about that! The fix is merged: e193bde7d75273a3272f264c42514f49a691658f
----- Original Message ----- > From: "David Caro" <[email protected]> > To: "Tomas Jelinek" <[email protected]> > Cc: "infra" <[email protected]> > Sent: Thursday, April 10, 2014 5:50:24 PM > Subject: Findbugs issue on engine > > Hi Tomas! > > One of your commits (not sure if 77de5a2fc23e5090934003848ceedcece29ca698 or > d19e7776918d0aba6b833c496e05630195609994) introduced a new findbugs error on > ovirt-engine/master, can you take a look please? > > """ > CloneVmCommand.java:214, EC_UNRELATED_TYPES, Priority: High รง > > Call to org.ovirt.engine.core.common.utils.VmDeviceType.equals(String) in > org.ovirt.engine.core.bll.CloneVmCommand.containsDeviceWithType(List, > VmDeviceGeneralType, VmDeviceType) > > This method calls equals(Object) on two references of different class types > with no common subclasses. Therefore, the objects being compared are unlikely > to > be members of the same class at runtime (unless some application classes were > not analyzed, or dynamic class loading can occur at runtime). According to > the > contract of equals(), objects of different classes should always compare as > unequal; therefore, according to the contract defined by > java.lang.Object.equals(Object), the result of this comparison will always be > false at runtime. > """ > > Thanks! > > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > Email: [email protected] > Web: www.redhat.com > RHT Global #: 82-62605 > > _______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
