----- Original Message ----- > From: "David Caro" <[email protected]> > To: "Greg Sheremeta" <[email protected]> > Cc: "Eyal Edri" <[email protected]>, [email protected], [email protected] > Sent: Tuesday, December 9, 2014 11:09:27 AM > Subject: Re: findbugs errors -- any way to prevent mad bot from rampant -1s? > > On 12/08, Greg Sheremeta wrote: > > Hi, > > > > Is there any way to prevent this [1] from happening? > > > > Some patch got merged that findbugs complains about. Basically no > > patches can be merged until that is fixed and everybody rebases > > everything (because the bot -1's everything). That doesn't seem right. > > What is not right is merging a patch that breaks findbugs. > > How do you suggest avoiding that? Ignoring the findbugs result always? > Forcing to pass it always? (that is, not allowing maintainers to > remove the jenkins reviewer). > If we only test you code (check out instead of cherry-pick) then you > will not have that issue, but you'll have to test anyhow the > cherry-pick before merging and we have the same issue + a lot of tests > on old code that when rebasing become opsolete. > > You could try to cross compare jobs running on merged code with the > jobs runing on non-merged code and disable voting if merged code is > breaking, but you will not be able to merge anyhow as you must make > sure the tests pass before merging, so you need a stable repo. > > > So in summary, yes there's something we can do, fix the offeding patch > (or revert it) and force any patchset to pass the tests before > merging. > >
totally agree. here's the offending patch that was merged both to master and to 3.5 stable branch: http://gerrit.ovirt.org/#/c/35931/ you can see clearly jenkins failed on it: Patch Set 3: Build Unstable http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/22350/ : SUCCESS http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/21862/ : The patch does not pass the findbugs http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/38550/ : SUCCESS so please either revert it or fix it to unblock all other patches. e. > > > > [1] http://i.imgur.com/NNHx1bq.png > > > > -- > > Greg Sheremeta > > Red Hat, Inc. > > Sr. Software Engineer, RHEV > > Cell: 919-807-1086 > > [email protected] > > _______________________________________________ > > Infra mailing list > > [email protected] > > http://lists.ovirt.org/mailman/listinfo/infra > > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > Tel.: +420 532 294 605 > Email: [email protected] > Web: www.redhat.com > RHT Global #: 82-62605 > > _______________________________________________ > Infra mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/infra > _______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
