----- Original Message ----- > From: "Francesco Romani" <[email protected]> > To: "David Caro" <[email protected]> > Cc: [email protected], [email protected] > Sent: Tuesday, December 9, 2014 11:48:00 AM > Subject: Re: [ovirt-devel] Creating a new gerrit flag > > ----- Original Message ----- > > From: "David Caro" <[email protected]> > > To: [email protected], [email protected] > > Sent: Tuesday, December 9, 2014 10:43:04 AM > > Subject: [ovirt-devel] Creating a new gerrit flag > > > > Hi! > > > > e have been having an issue with gerrit patches being merged before > > jenkins ran any tests on them, to avoid it from happening again I > > propose creating a new gerrit flag (Tests) with the following > > specifics: > > > > > > +1 - Tests passed/overrided > > 0 - Tests pending > > -1 - Tests broken > > > > where +1 is required to submit, +1 is set by jenkins when > > passing the tests and -1 is set by jenkins in case it breaks any > > tests. The +1 flag can be set also by maintainers to allow overriding > > the process. > > > > That way all the tests will be blocked until someone (hopefully > > jenkins) adds the +1 flag, but if the maintainer wants to override the > > value, she just has to set that flag herself. > > > > > > What do you think? > > Looks good, but there is a scenario which worries me a bit. > > It happened in the past times that an otherwise good and working patch > failed the tests because, for example, pep8 or pyflakes became stricter > about the code formatting. > > Can the maintainer override such a -1 from failed tests in that case? > (probably yes, but worth asking)
If a test fails on this, it will fail on all patches that will follow as well, so I don't think it's a bad requirement that you need to fix the underlying issues for patches to be merged. Without running tests you don't have any good wya to make sure a patch is 'good'. > > Thanks, > > -- > Francesco Romani > RedHat Engineering Virtualization R & D > Phone: 8261328 > IRC: fromani > _______________________________________________ > Devel mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/devel > _______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
