On Wed, Aug 12, 2015 at 2:42 PM, David Caro <[email protected]> wrote:
> On 08/12, Yevgeny Zaspitsky wrote: > > My bad, sorry. The findbugs job runs indeed. > > > > However look at that patch https://gerrit.ovirt.org/#/c/44604/ . > > Patch set 1 got Continuous-Integration+1 from Jenkins after running unit > > tests and then, much later, > > That much later is after merge, the findbugs ran once the patch was > merged. You > should understand that each event triggers a tests run, and for each tests > run > you get only one review. In this case the tests that check the code when > you > send the patch passed, but the ones that check the code after it's merged > failed. > In this case, I think we need the job which failed after merge to be run also on patch creation. > > > > Jenkins changed its mind and gave -1 after > > findbugs job has finished. > > IMHO that's is a misleading behavior. > > > > Regards, > > Yevgeny > > > > On Wed, Aug 12, 2015 at 12:12 PM, Sandro Bonazzola <[email protected]> > > wrote: > > > > > > > > > > > On Tue, Aug 11, 2015 at 6:13 PM, Yevgeny Zaspitsky < > [email protected]> > > > wrote: > > > > > >> Hi All, > > >> > > >> Seems like recently Jenkins has stopped running findbugs check on the > > >> patches before they get merged into master. Although that could save > some > > >> Jenkins resources and make the its reaction faster, that makes the > > >> integration (with master) check less effective. > > >> > > >> Was that done on purpose? Can that be restored for master patches? > > >> > > >> > > > AFAIK findbugs is still up and running: > > > http://jenkins.ovirt.org/search/?q=find-bugs > > > Have you any specific patch as example? > > > > > > > > > > > > > > >> Regards, > > >> Yevgeny > > >> > > >> _______________________________________________ > > >> Devel mailing list > > >> [email protected] > > >> http://lists.ovirt.org/mailman/listinfo/devel > > >> > > > > > > > > > > > > -- > > > Sandro Bonazzola > > > Better technology. Faster innovation. Powered by community > collaboration. > > > See how it works at redhat.com > > > > > > _______________________________________________ > > Infra mailing list > > [email protected] > > http://lists.ovirt.org/mailman/listinfo/infra > > > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > Tel.: +420 532 294 605 > Email: [email protected] > Web: www.redhat.com > RHT Global #: 82-62605 > -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
