On 11/13 08:55, Sandro Bonazzola wrote: > On Thu, Nov 12, 2015 at 3:45 PM, Nir Soffer <[email protected]> wrote: > > > Hi all, > > > > Our QE (and sometimes our users) are working hard testing and > > reporting bugs, but > > their effort is never mentioned in our code. > > > > Looking at kernel git history, I found that they are using the > > Reported-By header for > > giving credit to the person reporting a bug. I suggest we adapt this > > header. > > > > Here are some examples how we can use it: > > > > - https://gerrit.ovirt.org/#/c/48483/3//COMMIT_MSG > > - > > https://github.com/oVirt/vdsm/commit/fb4c72af5e4c200409c74834111d44d92959ebbd > > - > > https://github.com/oVirt/vdsm/commit/f8127d88add881a4775e7030dde2433125c7b598 > > > infra: looking at above commit messages, can we get automatically added the > following lines? > > Reviewed-on: https://gerrit.ovirt.org/46540 > on patch creation > > Reviewed-by: Francesco Romani <[email protected]> > on patch comment
There's no easy way to plug in extra stuff, that is done on vdsm by gerrit itself because the project is set to 'cherry-pick', but that has consequences, for starters, when you submit a patch, the commit that gets in is not the same that you where reviewing (as the commit message changed) and thus you will be forced to rebase all the patches that depended on it. There's no built-in way either to change the commit on push (when updating/creating the patch) without creating a new patch. That means that to have that added, each time you send a patch a new one will be created, and each time you add a comment for the first time to the patch, another patch will be created too. Forcing the devel to refetch the commit each time he/she pushes. Not sure that smoothes up the dev process... I think that the less painful path will be to use a commit hook locally, so the commit message is changed locally first, but that will require the dev to install it (we can ease that with a script or similar though) > > > > > > > > > Thanks, > > Nir > > _______________________________________________ > > Devel mailing list > > [email protected] > > http://lists.ovirt.org/mailman/listinfo/devel > > > > > > -- > Sandro Bonazzola > Better technology. Faster innovation. Powered by community collaboration. > See how it works at redhat.com > _______________________________________________ > Infra mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/infra -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: [email protected] Web: www.redhat.com RHT Global #: 82-62605
signature.asc
Description: PGP signature
_______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
