On 02/02 16:08, Yedidyah Bar David wrote: > On Tue, Feb 2, 2016 at 12:28 PM, David Caro <[email protected]> wrote: > > On 02/02 11:45, Yedidyah Bar David wrote: > >> (Sorry, this time to the right address) > >> > >> > >> ---------- Forwarded message ---------- > >> From: Yedidyah Bar David <[email protected]> > >> Date: Sun, Jan 31, 2016 at 1:20 PM > >> Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging: > >> rename: Handle storage domains more nicely > >> To: Jenkins CI <[email protected]> > >> > >> > >> On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <[email protected]> > >> wrote: > >> > Jenkins CI has posted comments on this change. > >> > > >> > Change subject: packaging: rename: Handle storage domains more nicely > >> > ...................................................................... > >> > > >> > > >> > Patch Set 1: Continuous-Integration-1 > >> > > >> > Build Failed > >> > > >> > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64/1312/ > >> > : FAILURE > >> > > >> > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64/1410/ > >> > : FAILURE > >> > >> Both of these are pep8: > >> > >> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:311:21: > >> E126 continuation line over-indented for hanging indent > >> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:312:21: > >> E126 continuation line over-indented for hanging indent > >> > >> > > >> > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_64/1004/ > >> > : SUCCESS > >> > >> How come this one passed? > >> > >> Do we have different versions/configuration of pep8 in different > >> OSes? > > > > Unless you are explicitly specifying a version of pep8 yes, they > > probably have different versions for different oses. > > Indeed, and el6 and el7 had old, buggy versions. > > > > >> > >> Also note that E126 is ignored by default, see e.g.: > >> > >> https://github.com/PyCQA/pep8/issues/265 > >> https://github.com/PyCQA/pep8/pull/360 > >> > > > > It's up to the project owners to decide what to test and how, for what > > I can see the script that runs pep8/pyflakes on the code is under, > > build/python-check.sh.in, and it was written by abarlev, so maybe you > > should talk to whomever inherited he's responsabilities (I don't know > > who that is, sorry, try on devel list) > > For el7 we already had a newer one on [1]. > > For el6 I built the srpm. > > Sandro now copied both to ci-tools [2] [3]. FYI and thanks.
Great :) > > [1] http://mirror.centos.org/centos/7/virt/x86_64/ovirt-3.6/common/ > [2] http://resources.ovirt.org/repos/ci-tools/el6/noarch/ > [3] http://resources.ovirt.org/repos/ci-tools/el7/noarch/ > > -- > Didi > _______________________________________________ > Infra mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/infra -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: [email protected] IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
signature.asc
Description: PGP signature
_______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
