You can see that Jenkins gave +1 in patchset 2 (which is identical to patchset 4 aside for the commit message, you can also see that those jobs started:
Build Started (1/2) -> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/598/ Build Started (2/2) -> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-fc23-x86_64/598/ Build Started -> http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/15450/ Build Started (1/4) -> http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-el7-x86_64/140/ Build Started (2/4) -> http://jenkins.ovirt.org/job/ovirt-engine_master_check-merged-fc23-x86_64/140/ Build Started (3/4) -> http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/146/ Build Started (4/4) -> http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged/141/ No findbugs job, if it did start there was no indication within the patch so the owner could not know he introduced a findbugs error. As for the DAO tests, I get it, a change in the common module triggers that as well, thanks. On Mon, May 9, 2016 at 4:32 PM, Shlomo Ben David <[email protected]> wrote: > Hi Nisan, > > 1. The findbugs job run at May 5 1:50 PM and returned with the following > msg: 'The patch does not pass the findbugs' > 2. The resource consuming DAO test run because there was a change in the > following file in the patch: > backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java > It's configured in Jenkins gerrit filters as a trigger. > > Best Regards, > > Shlomi Ben-David | Software Engineer | Red Hat ISRAEL > IRC: sbendavi > > OPEN SOURCE - 1 4 011 && 011 4 1 > > On Sun, May 8, 2016 at 10:34 PM, Tal Nisan <[email protected]> wrote: > >> Upon looking at another patch I saw that there's a new findbugs issue: >> >> http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45217/findbugsResult/new/ >> >> I've fixed the issue in this patch - https://gerrit.ovirt.org/57209 so >> it's all good now but I'm wondering why the findbugs job did not run in the >> first place. >> You can see that in the patch that introduced the issue - >> https://gerrit.ovirt.org/#/c/57054/ >> Also, why did the resource consuming DAO test ran although there were no >> changes in the dal module? >> >> >> _______________________________________________ >> Infra mailing list >> [email protected] >> http://lists.ovirt.org/mailman/listinfo/infra >> >> >
_______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
