On Wed, May 25, 2016 at 4:00 PM, Eyal Edri <[email protected]> wrote: > > > On Wed, May 25, 2016 at 3:43 PM, Tal Nisan <[email protected]> wrote: > >> >> >> On Wed, May 25, 2016 at 3:37 PM, Eyal Edri <[email protected]> wrote: >> >>> >>> >>> On Wed, May 25, 2016 at 3:33 PM, Tal Nisan <[email protected]> wrote: >>> >>>> >>>> >>>> On Wed, May 25, 2016 at 3:29 PM, Eyal Edri <[email protected]> wrote: >>>> >>>>> db upgrade jobs should be covered by engine-setup/upgrade so I don't >>>>> see a reason to keep running them. >>>>> >>>> You mean the checkpatch jobs cover them? Cause upgrade scripts changes >>>> need to be tested as well >>>> >>> >>> 2 things IMO cover this: >>> 1. the db duplicate script in check-patch.sh >>> 2. ovirt-engine setup/upgrade not in standard ci (since we can't run >>> setup on mock) >>> >>> If this is not the case, we need to migrate the db scripts to >>> check-patch. >>> >> Unless I got it all wrong I recall we had an upgrade script check on the >> old master, it seems like it's still running: >> >> http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_merged/ >> >> >> > That is not db upgrade, its the setup job I talked about and I think > sandro added it to 4.0 already. > It didn't run on the patch I sent as an example
> > > >> >>> >>>> >>>>> On Wed, May 25, 2016 at 3:29 PM, Eyal Edri <[email protected]> wrote: >>>>> >>>>>> Dao tests are run in the old jenkins still (pending migrate to >>>>>> standard ci - we'll appreciate help from DEV migrating it). >>>>>> Right now i'm cloning the jobs to run on 4.0 on old-jenkins. >>>>>> >>>>> What's needed for that migration? >>>> >>> >>> Just to copy the code to a bash script and test it, i started a very >>> draft and ugly code here: >>> >>> https://gerrit.ovirt.org/#/c/55808/ >>> >> Unfortunately we don't have the resources currently to help in that >> front, maybe other teams can help? >> Why not copy the existing behavior from old Jenkins though? >> > > We can't since they require local changes to the VMs which are not enabled > on new slaves in new jenkins. > For e.g - dao tests needs postgresql installed and configured - which we > can't enable on the new jenkins without breaking other stuff. > > The best solution will be to migrate this job to standard CI - so we need > a dev to sit with CI engineer - its also more complicated since we moved to > el7 and new postgres. > OK, guess that for now I'll either test DAO myself or make a system based on trust :) > > > >> >>> >>> >>> >>>> >>>>>> >>>>>> >>>>>> On Wed, May 25, 2016 at 3:11 PM, Tal Nisan <[email protected]> wrote: >>>>>> >>>>>>> Encountered that in this patch: >>>>>>> https://gerrit.ovirt.org/#/c/58034/ >>>>>>> >>>>>>> It introduces both an upgrade script change and a change in the DAO >>>>>>> layer yet it seems that DAO tests and upgrade test did not run >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Infra mailing list >>>>>>> [email protected] >>>>>>> http://lists.ovirt.org/mailman/listinfo/infra >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Eyal Edri >>>>>> Associate Manager >>>>>> RHEV DevOps >>>>>> EMEA ENG Virtualization R&D >>>>>> Red Hat Israel >>>>>> >>>>>> phone: +972-9-7692018 >>>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ) >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Eyal Edri >>>>> Associate Manager >>>>> RHEV DevOps >>>>> EMEA ENG Virtualization R&D >>>>> Red Hat Israel >>>>> >>>>> phone: +972-9-7692018 >>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ) >>>>> >>>> >>>> >>> >>> >>> -- >>> Eyal Edri >>> Associate Manager >>> RHEV DevOps >>> EMEA ENG Virtualization R&D >>> Red Hat Israel >>> >>> phone: +972-9-7692018 >>> irc: eedri (on #tlv #rhev-dev #rhev-integ) >>> >> >> > > > -- > Eyal Edri > Associate Manager > RHEV DevOps > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ) >
_______________________________________________ Infra mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/infra
