[
https://ovirt-jira.atlassian.net/browse/OVIRT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
eyal edri [Administrator] updated OVIRT-1037:
---------------------------------------------
Resolution: Duplicate
Status: Done (was: To Do)
OVIRT-1156
> Re: CI gives +1 on gerrit as a response to 'ci please build'.
> -------------------------------------------------------------
>
> Key: OVIRT-1037
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1037
> Project: oVirt - virtualization made easy
> Issue Type: By-EMAIL
> Reporter: eyal edri [Administrator]
> Assignee: infra
>
> Opening a ticket on it.
> We'll need to check which params to override in the new comment added
> trigger to not give +1.
> On Mon, Jan 16, 2017 at 10:01 PM, Barak Korren <[email protected]> wrote:
> > On 16 January 2017 at 16:14, Eyal Edri <[email protected]> wrote:
> > >
> > >
> > > On Mon, Jan 16, 2017 at 4:05 PM, Gil Shinar <[email protected]> wrote:
> > >>
> > >> Edy showed me the issue. I think we haven't thought about that.
> > >> 'ci please build' actually executes build artifacts jobs and when they
> > >> succeed, they change the "continuous integration" flag to +1.
> > >>
> > >> Can we control it from the Gerrit?
> >
> > No need we can do it from the job.
> >
> > > I couldn't find any reference for response from Jenkins to Grrit in the
> > yaml
> > > templates in std CI, so not sure its configurable per job, it might be on
> > > the main Jenkins configuration.
> > > Barak - do you know where the grading is defined for Gerrit Trigger in
> > YAML?
> >
> > Yeah you can use 'skip-vote" [1].
> > This requires Gerrit Trigger Plugin version >= 2.7.0
> >
> > [1]: http://docs.openstack.org/infra/jenkins-job-builder/
> > triggers.html#triggers.gerrit
> >
> >
> >
> >
> >
> > --
> > Barak Korren
> > [email protected]
> > RHCE, RHCi, RHV-DevOps Team
> > https://ifireball.wordpress.com/
> >
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R&D
> Red Hat Israel
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
--
This message was sent by Atlassian JIRA
(v1000.784.2#100032)
_______________________________________________
Infra mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/infra
