[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37535#comment-37535
 ] 

Milan Zamazal edited comment on OVIRT-2348 at 7/19/18 3:38 PM:
---------------------------------------------------------------

The bug is in 004_basic_sanity.preview_snapshot_with_memory test. The following 
check for successful snapshot creation is used:

{code:python}
snapshot = test_utils.get_snapshot(engine, VM0_NAME, SNAPSHOT_DESC_MEM)
return (snapshot is not None and
        snapshot.snapshot_status == types.SnapshotStatus.OK)
{code}

However the check passes even when the snapshot is not finished yet, resulting 
in the reported bug. There is add_vm_pool test running between snapshot start 
and that check. If snapshot creation is faster than adding a VM pool, which 
seems to be the regular case, the check doesn't matter and the failure doesn't 
occur. So the problem is not much urgent. I don't know yet what's wrong with 
the check, but I'll try to fix it.

Please note there is an unrelated bug causing the test name reported being 
test_gen rather than the actual test name. It was introduced in a recent OST 
change and a fix is posted: https://gerrit.ovirt.org/93167. It can be merged as 
soon as CI passes (it's currently stuck, waiting on an available executor).



was (Author: [email protected]):
The bug is in 004_basic_sanity.preview_snapshot_with_memory test. The following 
check for successful snapshot creation is used:

{code:python}
snapshot = test_utils.get_snapshot(engine, VM0_NAME, SNAPSHOT_DESC_MEM)
return (snapshot is not None and
             snapshot.snapshot_status == types.SnapshotStatus.OK)
{code}

However the check passes even when the snapshot is not finished yet, resulting 
in the reported bug. There is add_vm_pool test running between snapshot start 
and that check. If snapshot creation is faster than adding a VM pool, which 
seems to be the regular case, the check doesn't matter and the failure doesn't 
occur. So the problem is not much urgent. I don't know yet what's wrong with 
the check, but I'll try to fix it.

Please note there is an unrelated bug causing the test name reported being 
test_gen rather than the actual test name. It was introduced in a recent OST 
change and a fix is posted: https://gerrit.ovirt.org/93167. It can be merged as 
soon as CI passes (it's currently stuck, waiting on an available executor).


> 004_basic_sanity.test_gen test failed for ovirt-master in vdsm project 
> -----------------------------------------------------------------------
>
>                 Key: OVIRT-2348
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2348
>             Project: oVirt - virtualization made easy
>          Issue Type: Bug
>            Reporter: Dafna Ron
>            Assignee: infra
>            Priority: High
>              Labels: ost_code_regression, ost_failures
>
> The patch that CQ marked seems to be related. 
> [[email protected]] the patch that failed CQ is: 
> https://gerrit.ovirt.org/#/c/93046/
> you can look at the build's logs here: 
> https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/8725/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-004_basic_sanity.py/
> the engine log shows several tasks that fail and then there is an exception: 
> https://pastebin.com/6f5QTZUH



--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100090)
_______________________________________________
Infra mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/[email protected]/message/REEAIT46K3O5NNTGBV6VKO7BXE7M2SJ7/

Reply via email to