[
https://ovirt-jira.atlassian.net/browse/OVIRT-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=38913#comment-38913
]
danken commented on OVIRT-2664:
-------------------------------
On Wed, Jan 30, 2019 at 8:55 PM Nir Soffer <[email protected]> wrote:
>
> When creating OST manual job, the UI select engine version 4.2 by default:
> https://jenkins.ovirt.org/job/ovirt-system-tests_manual/build?delay=0sec
>
> A developer that want to test engine master must change the version manually.
>
> I you forget to change the version, or just do not notice that there is engine
> version to choose, your job may succeed when it actually fail with engine
> master.
>
> Watching other developers start OST jobs, they do not notice that engine
> version must be selected, and treat it as the other options that most people
> do not care about.
>
> This is probably the reason why OST was broken for a week, and nobody
> complained about it, since default build used engine 4.2.
"nobody" is an underestimating diminutive for an esteemed group
including Dafna, Raz, Eyal and myself, just to name a few.
>
> How to fix:
>
> - The UI must be changed to require engine version selection. You cannot
> have default for this.
>
> The UI should show something like:
>
> ENGINE_VERSION: [select version] *required
>
> - The "Build" button must be disabled if no version was selected.
I'm not sure about it, as I hate input validation. Regardless, I think
it is time to make master the default for the manual job.
> OST runs engine 4.2 by default, misleading developers
> -----------------------------------------------------
>
> Key: OVIRT-2664
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2664
> Project: oVirt - virtualization made easy
> Issue Type: By-EMAIL
> Reporter: Nir Soffer
> Assignee: infra
>
> When creating OST manual job, the UI select engine version 4.2 by default:
> https://jenkins.ovirt.org/job/ovirt-system-tests_manual/build?delay=0sec
> A developer that want to test engine master must change the version
> manually.
> I you forget to change the version, or just do not notice that there is
> engine
> version to choose, your job may succeed when it actually fail with engine
> master.
> Watching other developers start OST jobs, they do not notice that engine
> version must be selected, and treat it as the other options that most people
> do not care about.
> This is probably the reason why OST was broken for a week, and nobody
> complained about it, since default build used engine 4.2.
> How to fix:
> - The UI must be changed to require engine version selection. You cannot
> have default for this.
> The UI should show something like:
> ENGINE_VERSION: [select version] *required
> - The "Build" button must be disabled if no version was selected.
> Nir
--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100098)
_______________________________________________
Infra mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct:
https://www.ovirt.org/community/about/community-guidelines/
List Archives:
https://lists.ovirt.org/archives/list/[email protected]/message/BUJT66PQIIV5U2L3RL7CPXEX45ZN42R7/
