[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41048#comment-41048
 ] 

Michal Skrivanek commented on OVIRT-3110:
-----------------------------------------

> On 10. 7. 2021, at 0:14, Nir Soffer <nsof...@redhat.com> wrote:
> 
> On Sat, Jul 10, 2021 at 12:59 AM Nir Soffer <nsof...@redhat.com> wrote:
>> 
>> OST failed, and posted unprocessed comment:
>> 
>>    OST Verified -1
>>    Patch Set 1: Verified-1
>>    https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 :
>> OST https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/$OST_NUMBER
>>    failed with: $OST_MESSAGE
>> 
>> https://gerrit.ovirt.org/c/vdsm/+/115642#message-b2993761_adbc1b6a
>> 
>> Looking at:
>> https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313
>> 
>> It looks like environment issue:
>> 
>> ERROR: Build step failed with exception
>> 
>> java.lang.NullPointerException: no workspace from node
>> hudson.slaves.DumbSlave[hpe-bl280g6-12...] which is computer
>> hudson.slaves.SlaveComputer@2e2cb321 and has channel null
>> 
>> So we have 2 issues:
>> 1. If build fails, error is not handled properly producing bad comment
>> 2. the actual build failure
> 
> I started another build manually (8543) and it started normally, so this was
> probably a temporary issue.

Seems someone rebooted the jenkins host in the middle of the run

> 
>> 
>> The first issue should be handled by posting a better comment:
>> 
>>    OST build error:
>> https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313
>> 
>> And OST should not mark the patch as verified -1, since it did not run any 
>> test.

It’s a shell script that runs after the job that fails on missing workspace, it 
would be possible to set unstable status on a failure of that script, but It 
doesn’t seem to be possible to handle internal jenkins exception

>> 
>> Marking a patch as -1 means some tests have failed,  and the author
>> needs to check
>> why. A build error means OST or CI maintainers need to check why the
>> error happened.
> _______________________________________________
> Devel mailing list -- de...@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/privacy-policy.html
> oVirt Code of Conduct: 
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives: 
> https://lists.ovirt.org/archives/list/de...@ovirt.org/message/H4Q2MT7R7DXKWHRZK7RGPSOLRYZMVZOP/

> OST failure, bad comment
> ------------------------
>
>                 Key: OVIRT-3110
>                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3110
>             Project: oVirt - virtualization made easy
>          Issue Type: By-EMAIL
>            Reporter: Nir Soffer
>            Assignee: infra
>
> OST failed, and posted unprocessed comment:
>     OST Verified -1
>     Patch Set 1: Verified-1
>     https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313 :
> OST https://redir.apps.ovirt.org/dj/job/ds-ost-baremetal_manual/$OST_NUMBER
>     failed with: $OST_MESSAGE
> https://gerrit.ovirt.org/c/vdsm/+/115642#message-b2993761_adbc1b6a
> Looking at:
> https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313
> It looks like environment issue:
> ERROR: Build step failed with exception
> java.lang.NullPointerException: no workspace from node
> hudson.slaves.DumbSlave[hpe-bl280g6-12...] which is computer
> hudson.slaves.SlaveComputer@2e2cb321 and has channel null
> So we have 2 issues:
> 1. If build fails, error is not handled properly producing bad comment
> 2. the actual build failure
> The first issue should be handled by posting a better comment:
>     OST build error:
> https://redir.apps.ovirt.org/dj/job/ds-ost-gating-trigger2/313
> And OST should not mark the patch as verified -1, since it did not run any 
> test.
> Marking a patch as -1 means some tests have failed,  and the author
> needs to check
> why. A build error means OST or CI maintainers need to check why the
> error happened.



--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100168)
_______________________________________________
Infra mailing list -- infra@ovirt.org
To unsubscribe send an email to infra-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/infra@ovirt.org/message/IV2I2UGBTESUYZXUKLZT5XFLQIHKE533/

Reply via email to