On 04/19/2013 04:12 PM, Toshio Kuratomi wrote:
> Today a bug was reported in fas.  Symptoms are the first time someone trie to
> sign the FPCA it fails.  A subsequent attempt will succeed.  The reason is a 
> typo
> in one code path through the fpca signing process.  The fix is a simple
> correction of the typo and should be easy to revert if it causes unexpected
> problems.
> 
> May I get two +1's to apply this as a hotfix?

+1, easy enough to revert it if something goes awry.

> 
> 
> diff --git a/fas/fpca.py b/fas/fpca.py
> index 198a1c6..7cf6a9c 100644
> --- a/fas/fpca.py
> +++ b/fas/fpca.py
> @@ -338,7 +338,7 @@ def send(self, human_name, telephone, country_code, 
> postal_address=None,
>              person.apply(group, person) # Apply for the new group
>              session.flush()
>  
> -            fas.fas.fedmsgshimshim.send_message(topic="group.member.apply", 
> msg={
> +            fas.fedmsgshim.send_message(topic="group.member.apply", msg={
>                  'agent': person.username,
>                  'user': person.username,
>                  'group': group.name,
> 
> 
> 
> _______________________________________________
> infrastructure mailing list
> [email protected]
> https://admin.fedoraproject.org/mailman/listinfo/infrastructure
> 


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
infrastructure mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/infrastructure

Reply via email to