On Tue, Sep 09, 2014 at 08:58:58AM -0600, Tim Flink wrote:
> +@api_v0.route('/milestones/current')
> +def get_current_milestone():
> + current_milestone = get_or_404(Milestone, current=True)
> + return JsonResponse(current_milestone.simple())> - def sync(self, updateinfo, milestone): > + def sync(self, updateinfo, fullsync=False): > @classmethod > - def from_data(cls, updateinfo, release, milestone): > + def from_data(cls, updateinfo, release): These are the two places which scare me a little since you are replacing an argument with another. So assuming you have checked that the function calls were updated everywhere to the new behavior/arguments, +1 for me. Pierre
pgpMS_Whp8KyC.pgp
Description: PGP signature
_______________________________________________ infrastructure mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/infrastructure
