Re: Restructuring hooks in dist-git

[Pierre-Yves Chibon]

On Thu, Sep 07, 2017 at 11:59:22AM -0700, Kevin Fenzi wrote:
> On 09/07/2017 07:12 AM, Pierre-Yves Chibon wrote:
> > Good Morning Everyone,
> > ...snip...
> 
> > What do you think? I know we are in freeze but this shouldn't impact 
> > directly
> > anything release-related. Worth trying now or should it wait some more?
> 
> I like it and it should hopefully make it easy for me to add grokmirror
> hooks. ;)
> 
> Can you do it in stg and test and confirm all works ok?

I just manually adjusted things in stg, so let's see if it works :)

> Also, should we renable check perms cron? I don't see that in this
> patchset.

I manually adjusted it in stg but this is the change to put in ansible:

diff --git a/ roles/distgit/tasks/main.yml b/ roles/distgit/tasks/main.yml
index 42e7097..f6045a9 100644
--- a/ roles/distgit/tasks/main.yml
+++ b/ roles/distgit/tasks/main.yml
@@ -142,7 +142,7 @@
     name="check-update-hooks" cron_file="ansible-check-update-hooks"
     minute=0 hour=0 weekday=3
     user=nobody
-    job="MAILTO=root PATH=/usr/bin:/usr/local/bin git check-perms 
--check=update-hook /srv/git/repositories}}"
+    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms 
--check=update-hook /srv/git/repositories"
   tags:
   - distgit

diff --git a/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml b/ 
roles/gitolite/check_fedmsg_hooks/tasks/main.yml
index b0047c9..afa0c61 100644
--- a/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml
+++ b/ roles/gitolite/check_fedmsg_hooks/tasks/main.yml
@@ -9,4 +9,4 @@
     hour=0
     weekday=3
     user=nobody
-    job="MAILTO=root PATH=/usr/bin:/usr/local/bin git check-perms /git 
--check=fedmsg-hook"
+    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms 
/srv/git/repositories --check=fedmsg-hook"


> I'm somewhat leary of doing this in freeze, but if it looks ok in stg I
> suppose it would be ok.

My biggest concern is the lack of fedmsg notifications on new repos.
After I guess it all depends on how long freeze is going to be :s


Pierre

signature.asc
Description: PGP signature

_______________________________________________
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org