Ismael Luceno schrieb:
> dragoran escribió:
>
>> Ismael Luceno wrote:
>>
>>> I think we should have a pre-release as shortly as possible.
>>>
>>> Why?, because 0.6.8 is very buggy, and svn appears to be rock-solid.
>>>
>>>
>>>
>> +1
>> is the virtual isse with the events solved?
>>
>
> Yes, and I fixed the last plugin also.
>
>
good work :)
> The only thing I have left is to know if the dbus and selinux plugins
> build (i think selinux does...).
>
>
dbus does not build:
[ 56%] Building C object
plugins/dbus_event/CMakeFiles/dbusevent.dir/initng_dbusevent.o
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'add_dbus_watch':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:112:
error: 'EVENT_FD_WATCHER' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:112:
error: (Each undeclared identifier is reported only once
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:112:
error: for each function it appears in.)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'free_dbus_watch_data':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:149:
error: 'EVENT_FD_WATCHER' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'astatus_change':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:176:
error: 'service_db_h' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:176:
error: 'service' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:181:
error: 'EVENT_STATE_CHANGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: At
top level:
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:235:
error: conflicting types for 'system_state_change'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:67:
error: previous declaration of 'system_state_change' was here
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'system_state_change':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:240:
error: 'EVENT_SYSTEM_CHANGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:243:
error: incompatible types in assignment
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: At
top level:
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:284:
error: conflicting types for 'system_pipe_watchers'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:69:
error: previous declaration of 'system_pipe_watchers' was here
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'system_pipe_watchers':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:288:
error: 'EVENT_PIPE_WATCHER' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:291:
error: 's_event_pipe_watcher_data' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:291:
error: expected expression before ')' token
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:292:
error: expected expression before ')' token
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:311:
error: 'output' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: At
top level:
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:334:
error: conflicting types for 'print_error'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:71:
error: previous declaration of 'print_error' was here
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'print_error':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:335:
error: 's_event_error_message_data' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:335:
error: 'data' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:339:
error: 'EVENT_ERROR_MESSAGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: At
top level:
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:394:
error: conflicting types for 'check_socket'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:65:
error: previous declaration of 'check_socket' was here
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'check_socket':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:397:
error: 'EVENT_SIGNAL' undeclared (first use in this function)
cc1: warnings being treated as errors
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:399:
warning: assignment makes integer from pointer without a cast
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'module_init':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:473:
warning: implicit declaration of function 'initng_event_hook_register'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:473:
warning: nested extern declaration of 'initng_event_hook_register'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:473:
error: 'EVENT_SIGNAL' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:474:
error: 'EVENT_STATE_CHANGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:475:
error: 'EVENT_SYSTEM_CHANGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:476:
error: 'EVENT_PIPE_WATCHER' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:477:
error: 'EVENT_ERROR_MESSAGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c: In
function 'module_unload':
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:495:
warning: implicit declaration of function 'initng_event_hook_unregister'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:495:
warning: nested extern declaration of 'initng_event_hook_unregister'
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:495:
error: 'EVENT_SIGNAL' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:496:
error: 'EVENT_STATE_CHANGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:497:
error: 'EVENT_SYSTEM_CHANGE' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:498:
error: 'EVENT_PIPE_WATCHER' undeclared (first use in this function)
/home/dragoran/initng.build/plugins/dbus_event/initng_dbusevent.c:499:
error: 'EVENT_ERROR_MESSAGE' undeclared (first use in this function)
make[2]: ***
[plugins/dbus_event/CMakeFiles/dbusevent.dir/initng_dbusevent.o] Error 1
make[1]: *** [plugins/dbus_event/CMakeFiles/dbusevent.dir/all] Error 2
make: *** [all] Error 2
(will see what I can do)
Selinux does not build too because of this:
const char *selinux_context = get_string(&SELINUX_CONTEXT, s);
s used to be active_db_h * s
but now the function changed from:
static int set_selinux_context(active_db_h * s, process_h * p
__attribute__ ((unused)))
to
static int set_selinux_context(s_event * event)
whats the replacement for active_db_h
event->data ? (it complains that event is no struct)
there was some other issue (unused var) which I fixed by commenting out
for now.
>>> There are some things still left, like the selinux and dbus stuff,
>>> if someone could test that I will try to fix any issue ;).
>>>
>>>
>>>
>> selinux still have issues with file descriptor leaks which needs to be
>> fixed.
>> there are some scripts (like mount) which do not call close which causes
>> the filedescriptor to be reused (but with a different securitycontext)
>> so the other initscripts does not have access to it.
>>
>>
yes it has always been there but I don't think that its ifiles related
because the don't call open(), but its related to the code which
executed them,
>
> If it's only ifiles related it could wait, and if not, it was there
> before, so it's not so important for a pre-release...
>
>
--
_______________________________________________
Initng mailing list
[email protected]
http://jw.dyndns.org/mailman/listinfo/initng
