Patrick LeBoutillier wrote:
>
> Hi all,
>
> I've just released Inline::Java pre-0.01 on the Inline::Java development
> site:
>
> http://ttul.org/~patrick
Patrick,
This looks great. I have high hopes for Inline::Java. Here are some
random notes:
- Couldn't figure out how to build the SDK on my Linux box. I can tell
you right now that your doc should include easy to follow instructions
on how to install the prerequisites for the Java challenged. Don't
assume an expertise in Java by your users. I learned C from Inline::C.
;)
- Looking over your code...
- Just FYI. In Perl, $ref->{foo}->[42]->{bar} can always be written as
$ref->{foo}[42]{bar}. Only one '->' is needed.
- I would prefer the register() type to be 'interpreted' rather than
'compiled'. 'compiled' is for ILSM-s that use DynaLoader. 'interpreted'
really means 'non-compiled'. This is minor.
- For configuration parameter names, it is not necessary to prefix all
of them with 'JAVA_'. It is fine for 2 ILSM-s to share the same Config
option names. I would avoid prefixing except for 2 cases:
1) If the prefixed name has an accepted meaning to Java already.
2) If the name is (or will be) a generic Inline option. DEBUG will be
used by Inline in the future. You may wish to use DEBUG for now anyway,
and it still may do the right thing when I implement debugging. But if
you have different semantics, you'll need to change it.
- For things like JAVA_BIN, you may want to call it INLINE_JAVA_BIN or
even PERL_INLINE_JAVA_BIN externally (%ENV), and just BIN internally. I
use
$ENV{PERL_INLINE_DIRECTORY}
and
use Inline C => 'source' => DIRECTORY => ...
to mean the same thing. Some other software may use the JAVA_BIN env
variable differently.
That's all for now. I wish I could get it running. I'll try again later.
If anyone wants to give me a pointer, I'm running Linux 2.2.13 (Suse
6.3)
Cheers (and lots of them :), Brian
PS On last thing. It's OK to use names like
'Inline-Java-0.01-dev-001.tar.gz' internally, but please don't upload
anything like that to CPAN. Just use whatever 'make dist' produces. This
helps CPAN maintainers (like me) a lot.
Version numbers in Perl should not contain any/much overloaded meaning
except that they should increase in number value. They should always be
'#.##'. It doesn't matter at all what number you start with on CPAN.
My personal preference is to always increase by 0.01, and round to 0.10
for major releases.
>
> It should be pretty stable, but not yet CPAN stuff. If anybody wants to toy
> around with it, be my guest. I've tested it with Perl 5.6.0, on Solaris
> 2.5.1 with Java SDK 1.2.1.
>
> All comments/bugs/suggestions/questions welcome.
>
> What I'm looking for most are configurations on which you were able to run
> the tests succesfully. Unix should work fine. I'm not sure about Windows.
> I'll try to get it going on my PC because there are certainly a few
> portability issues.
>
> Documentation should be ok, but might not be 100% complete.
>
> Thanks and have fun,
>
> Patrick LeBoutillier
>
> _________________________________________________________________________
> Get Your Private, Free E-mail from MSN Hotmail at http://www.hotmail.com.
--
perl -le 'use Inline C=>q{SV*JAxH(char*x){return newSVpvf
("Just Another %s Hacker",x);}};print JAxH+Perl'
