Thanks. I'll look into developing some tests. How do we want to build up a test suite - as the dependency is on an ILSM not on Inline perse?
CHeers. On Tue, Oct 15, 2002 at 06:51:42PM -0400, Mitchell N Charity wrote: > I've got a problem with this one for the Installable CPP module: > [...] > Where do I start looking? > > It looks like the > my @dirparts = (grep($_, File::Spec->splitdir($dir)), $file); > line in Inline.pm. > > Here is a patch backward from TRIAL4 to an earlier version of Brian's > code (he was planning on backing out the grep, but I guess it didn't > make TRAIL4). > > $ cd Inline-0.44-TRIAL4 > $ patch < attached_patch > > The patched version "make test"'s ok, and works on your example. > I've not exercised it beyond that. > > I've taken the liberty of also rolling back the $dirparts[-1] test, > which was another change that worried me. > > Looks like some module installation test cases are needed. > Volunteers? > > Mitchell > > ========== > --- Inline.pm Tue Oct 15 18:17:56 2002 > +++ Inline.pm.new Tue Oct 15 18:17:44 2002 > @@ -432,10 +432,12 @@ > or croak M27_module_not_indexed($realname); > > my ($volume,$dir,$file) = File::Spec->splitpath($realpath); > - my @dirparts = (grep($_, File::Spec->splitdir($dir)), $file); > + my @dirparts = File::Spec->splitdir($dir); > + pop @dirparts unless $dirparts[-1]; > + push @dirparts, $file; > my @endparts = splice(@dirparts, 0 - @pkgparts); > - > - $dirparts[-1] = 'arch' if "@dirparts[-2, -1]" eq 'blib lib'; > + $dirparts[-1] = 'arch' > + if $dirparts[-2] eq 'blib' && $dirparts[-1] eq 'lib'; > File::Spec->catfile(@endparts) eq $realname > or croak M28_error_grokking_path($realpath); > $realpath = > ==========
