Send inn-committers mailing list submissions to
inn-committers@lists.isc.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-committers
or, via email, send a message with subject or body 'help' to
inn-committers-requ...@lists.isc.org
You can reach the person managing the list at
inn-committers-ow...@lists.isc.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-committers digest..."
Today's Topics:
1. INN commit: trunk/lib (getaddrinfo.c) (INN Commit)
2. INN commit: trunk (doc/pod/inn.conf.pod
storage/tradspool/tradspool.c) (INN Commit)
3. INN commit: branches/2.5 (2 files) (INN Commit)
----------------------------------------------------------------------
Message: 1
Date: Mon, 17 Feb 2014 10:47:20 -0800 (PST)
From: INN Commit <r...@isc.org>
To: inn-committ...@isc.org
Subject: INN commit: trunk/lib (getaddrinfo.c)
Message-ID: <20140217184720.b244167...@hope.eyrie.org>
Date: Monday, February 17, 2014 @ 10:47:20
Author: iulius
Revision: 9606
sync with latest rra-c-util
Don't check whether a pointer is NULL before passing it into free
and instead assume free can handle NULL pointers properly. This
has been true for many years.
Modified:
trunk/lib/getaddrinfo.c
---------------+
getaddrinfo.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Modified: getaddrinfo.c
===================================================================
--- getaddrinfo.c 2014-02-17 18:04:21 UTC (rev 9605)
+++ getaddrinfo.c 2014-02-17 18:47:20 UTC (rev 9606)
@@ -153,10 +153,8 @@
while (ai != NULL) {
next = ai->ai_next;
- if (ai->ai_addr != NULL)
- free(ai->ai_addr);
- if (ai->ai_canonname != NULL)
- free(ai->ai_canonname);
+ free(ai->ai_addr);
+ free(ai->ai_canonname);
free(ai);
ai = next;
}
------------------------------
Message: 2
Date: Mon, 17 Feb 2014 11:11:31 -0800 (PST)
From: INN Commit <r...@isc.org>
To: inn-committ...@isc.org
Subject: INN commit: trunk (doc/pod/inn.conf.pod
storage/tradspool/tradspool.c)
Message-ID: <20140217191131.3443b67...@hope.eyrie.org>
Date: Monday, February 17, 2014 @ 11:11:30
Author: iulius
Revision: 9607
improve documentation about using storeonxref with tradspool
Mention in the inn.conf man page that storeonxref needs being set to
true in case the tradspool article storage method is used.
Though a few parts of tradspool handle both values for storeonxref, the
implementation when storeonxref is false is not complete. For instance,
CrackXref() is still called on the Newsgroups: header once, which
obviously fails.
Modified:
trunk/doc/pod/inn.conf.pod
trunk/storage/tradspool/tradspool.c
-------------------------------+
doc/pod/inn.conf.pod | 3 +++
storage/tradspool/tradspool.c | 5 +++++
2 files changed, 8 insertions(+)
Modified: doc/pod/inn.conf.pod
===================================================================
--- doc/pod/inn.conf.pod 2014-02-17 18:47:20 UTC (rev 9606)
+++ doc/pod/inn.conf.pod 2014-02-17 19:11:30 UTC (rev 9607)
@@ -593,6 +593,9 @@
rather than according to the newsgroups the control messages are posted
to. This is a boolean value and the default is true.
+If the tradspool article storage method is used, I<storeonxref> must
+be true.
+
=item I<useoverchan>
Whether to innd(8) should create overview data internally through
Modified: storage/tradspool/tradspool.c
===================================================================
--- storage/tradspool/tradspool.c 2014-02-17 18:47:20 UTC (rev 9606)
+++ storage/tradspool/tradspool.c 2014-02-17 19:11:30 UTC (rev 9607)
@@ -454,6 +454,11 @@
SMseterror(SMERR_INTERNAL, "attr is NULL");
return false;
}
+ /* Though a few parts of tradspool handle both values for storeonxref,
+ * the implementation when storeonxref is false is not complete.
+ * For instance, CrackXref() is still called on the Newsgroups: header
+ * once, which obviously fails.
+ */
if (!innconf->storeonxref) {
warn("tradspool: storeonxref needs to be true");
SMseterror(SMERR_INTERNAL, "storeonxref needs to be true");
------------------------------
Message: 3
Date: Mon, 17 Feb 2014 11:12:16 -0800 (PST)
From: INN Commit <r...@isc.org>
To: inn-committ...@isc.org
Subject: INN commit: branches/2.5 (2 files)
Message-ID: <20140217191216.506af67...@hope.eyrie.org>
Date: Monday, February 17, 2014 @ 11:12:15
Author: iulius
Revision: 9608
improve documentation about using storeonxref with tradspool
Mention in the inn.conf man page that storeonxref needs being set to
true in case the tradspool article storage method is used.
Though a few parts of tradspool handle both values for storeonxref, the
implementation when storeonxref is false is not complete. For instance,
CrackXref() is still called on the Newsgroups: header once, which
obviously fails.
Modified:
branches/2.5/doc/pod/inn.conf.pod
branches/2.5/storage/tradspool/tradspool.c
-------------------------------+
doc/pod/inn.conf.pod | 3 +++
storage/tradspool/tradspool.c | 5 +++++
2 files changed, 8 insertions(+)
Modified: doc/pod/inn.conf.pod
===================================================================
--- doc/pod/inn.conf.pod 2014-02-17 19:11:30 UTC (rev 9607)
+++ doc/pod/inn.conf.pod 2014-02-17 19:12:15 UTC (rev 9608)
@@ -593,6 +593,9 @@
rather than according to the newsgroups the control messages are posted
to. This is a boolean value and the default is true.
+If the tradspool article storage method is used, I<storeonxref> must
+be true.
+
=item I<useoverchan>
Whether to innd(8) should create overview data internally through
Modified: storage/tradspool/tradspool.c
===================================================================
--- storage/tradspool/tradspool.c 2014-02-17 19:11:30 UTC (rev 9607)
+++ storage/tradspool/tradspool.c 2014-02-17 19:12:15 UTC (rev 9608)
@@ -454,6 +454,11 @@
SMseterror(SMERR_INTERNAL, "attr is NULL");
return false;
}
+ /* Though a few parts of tradspool handle both values for storeonxref,
+ * the implementation when storeonxref is false is not complete.
+ * For instance, CrackXref() is still called on the Newsgroups: header
+ * once, which obviously fails.
+ */
if (!innconf->storeonxref) {
warn("tradspool: storeonxref needs to be true");
SMseterror(SMERR_INTERNAL, "storeonxref needs to be true");
------------------------------
_______________________________________________
inn-committers mailing list
inn-committers@lists.isc.org
https://lists.isc.org/mailman/listinfo/inn-committers
End of inn-committers Digest, Vol 60, Issue 3
*********************************************
