Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Patches: improve innconf.h, remove obsolete docs
(Richard Kettlewell)
2. Re: Patches: improve innconf.h, remove obsolete docs
(Russ Allbery)
3. Re: Patches: improve innconf.h, remove obsolete docs
(Richard Kettlewell)
----------------------------------------------------------------------
Message: 1
Date: Sat, 23 Feb 2013 14:36:05 +0000
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Patches: improve innconf.h, remove obsolete docs
Message-ID: <[email protected]>
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Attached are a couple of suggested patches to INN to improve the
experience of external programs that use /usr/include/inn and
/usr/lib/libinn.a.
HAVE_SSL.diff makes the layout of the innconf structure independent of
INN's build options. External programs have no idea how INN was built
and it's (at best) tedious for them to have to work it out.
HeaderFind.diff removes some long-obsolete documentation.
ttfn/rjk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: HAVE_SSL.diff
Type: text/x-patch
Size: 1110 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20130223/b0df487c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: HeaderFind.diff
Type: text/x-patch
Size: 1270 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20130223/b0df487c/attachment-0003.bin>
------------------------------
Message: 2
Date: Sat, 23 Feb 2013 14:52:42 -0800
From: Russ Allbery <[email protected]>
To: Richard Kettlewell <[email protected]>
Cc: [email protected]
Subject: Re: Patches: improve innconf.h, remove obsolete docs
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Richard Kettlewell <[email protected]> writes:
> Attached are a couple of suggested patches to INN to improve the
> experience of external programs that use /usr/include/inn and
> /usr/lib/libinn.a.
> HAVE_SSL.diff makes the layout of the innconf structure independent of
> INN's build options. External programs have no idea how INN was built and
> it's (at best) tedious for them to have to work it out.
> HeaderFind.diff removes some long-obsolete documentation.
Thanks, applied.
--
Russ Allbery ([email protected]) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
------------------------------
Message: 3
Date: Sun, 24 Feb 2013 11:36:55 +0000
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Re: Patches: improve innconf.h, remove obsolete docs
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
On 23/02/13 22:52, Russ Allbery wrote:
> Richard Kettlewell <[email protected]> writes:
>> Attached are a couple of suggested patches to INN to improve the
>> experience of external programs that use /usr/include/inn and
>> /usr/lib/libinn.a.
>
>> HAVE_SSL.diff makes the layout of the innconf structure independent of
>> INN's build options. External programs have no idea how INN was built and
>> it's (at best) tedious for them to have to work it out.
>
>> HeaderFind.diff removes some long-obsolete documentation.
>
> Thanks, applied.
Taking the same thought a bit further: these headers are pretty free in
their use of namespace. For instance, xmalloc is very likely to clash
with a symbol of similar meaning (but not necessarily an identical one)
in any nontrivial program. Would a patch to improve this be likely to
be accepted?
What I have in mind is:
(1) All publicly visible symbols renamed to start inn_
(or INN_ for things already all upper-case).
(2) A collection of #defines to provide the same symbols as now.
(3) An INN_COMPATIBLE_NAMESPACE define. If set to 1 the #defines
in (2) are enabled, if set to 0 they are disabled.
The default value for INN_COMPATIBLE_NAMESPACE is 1.
(4) Some kind of build-time test to detect future namespace
leakage. (This might be limited to easy platforms, but
it only actually needs to work on popular platforms to
achieve the desired effect.)
(2) and (3) mean that existing code, including the bulk of INN, requires
no change.
And maybe:
(5) Build the INN libraries as a shared library (or as a collection of
shared libraries). I can see that this might be more controversial,
as it would more caution about interface changes than INN has
presumably required in the past.
ttfn/rjk
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 48, Issue 2
******************************************
