Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: double 'ctlinnd flushlogs' deletes news, errlog
(John F. Morse)
----------------------------------------------------------------------
Message: 1
Date: Wed, 10 Apr 2013 10:35:06 -0500
From: "John F. Morse" <[email protected]>
To: [email protected]
Subject: Re: double 'ctlinnd flushlogs' deletes news, errlog
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1
Hi Florian,
On 04/10/2013 05:14 AM, Florian Schlichting wrote:
> Hi Julien,
>
> I just noticed a critical flaw in your recent commit to flush process /
> exploder channels. You introduced a second call to 'ctlinnd flushlogs'
> in scanlogs. Unfortunately, when 'ctlinnd flushlogs' is called, innd
> doesn't just flush its logs, it also rotates (moves) its log and errlog
> to news.old and errlog.old, overwriting what's already there. So the
> second call effectively destroys both logs. This happens in
> innd/innd.c:ReopenLog().
>
> From ctlinnd(8):
>
> flushlogs
> Close the news and error log files and rename them to add ".old" to
> the file name, then open fresh news and error logs.
>
> Perhaps innd should stop do the .old rotation and restrict itself to
> flushing, and scanlogs should mv to .old rather than cp, and not just
> "in case innd is down", and the then the first invocation of 'ctlinnd
> flushlogs' can be deleted?
>
> Florian
I would prefer the addition to the filename be the ISO 8601 date and time.
This certainly provides more information than ".old" plus making sorts easy,
and would eliminate overwrites.
--
John
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 50, Issue 2
******************************************
