Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: Odd issue with pod2man when building on Fedora build
server (Julien ?LIE)
2. Re: Odd issue with pod2man when building on Fedora build
server (Russ Allbery)
----------------------------------------------------------------------
Message: 1
Date: Fri, 24 May 2013 21:48:57 +0200
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: Odd issue with pod2man when building on Fedora build
server
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252
Hi Jochen,
I have just had a look at the existing patches in your Fedora build.
Do you believe some of them would be worthwhile taking into account in upstream?
Here are a few comments:
--- inn-2.4.3/innfeed/imap_connection.c.warn 2006-03-20 05:14:57.000000000
+0100
+++ inn-2.4.3/innfeed/imap_connection.c 2006-03-27 12:07:20.000000000 +0200
@@ -2452,7 +2452,7 @@
char *p;
#ifdef HAVE_SASL
- const char *mechusing;
+ const char *mechusing = NULL;
int saslresult=SASL_NOMECH;
sasl_interact_t *client_interact=NULL;
=> Is it really necessary?
Which warning is suppressed with this patch? I do not see one when building.
We can have this change in upstream if it fixes something for Fedora.
--- inn-2.5.1/doc/pod/rc.news.pod.nologin 2009-10-12 20:24:04.000000000
+0200
+++ inn-2.5.1/doc/pod/rc.news.pod 2009-10-13 21:53:35.000000000 +0200
@@ -63,16 +63,16 @@ is recommended to throttle the server fi
To start INN and leave certain error messages going to the terminal:
- su - news -c <pathbin in inn.conf>/rc.news
+ su -m news -c /etc/rc.news
=> Is rc.news really installed as /etc/rc.news in Fedora, and not in a
subdirectory
of /etc?
Maybe the "-m" option could be used in our examples; I will have a look.
--- inn-2.5.3/innfeed/configfile.l.lex 2012-09-11 14:29:00.473000388 +0200
+++ inn-2.5.3/innfeed/configfile.l 2012-09-11 14:29:40.108999869 +0200
@@ -36,7 +36,7 @@ static void yyunput(int, char *) UNUSED;
int yyget_lineno(void);
FILE *yyget_in(void);
FILE *yyget_out(void);
-int yyget_leng(void);
+// int yyget_leng(void);
char *yyget_text(void);
int yyget_debug(void);
void yyset_lineno(int);
=> What problem are fixing with this change?
--- inn-2.5.2/storage/cnfs/cnfs.h.posix 2010-03-24 21:10:36.000000000 +0100
+++ inn-2.5.2/storage/cnfs/cnfs.h 2010-06-28 17:33:11.106804964 +0200
@@ -18,4 +18,12 @@ void cnfs_printfiles(FILE *file, TOKEN t
char *cnfs_explaintoken(const TOKEN token);
void cnfs_shutdown(void);
+/* Patch for POSIX */
+
+#ifndef MADV_SEQUENTAL
+ #ifdef POSIX_MADV_SEQENTIAL
+ #define MADV_SEQUITIAL POSIX_MADV_SEQUENTIAL
+ #endif
+#endif
+
#endif
=> I will have a look at this one. Is there a specific architecture that
needs this definition?
--- inn-2.5.1/storage/buffindexed/ovmethod.mk.shared 2009-12-01
16:50:37.174811272 +0100
+++ inn-2.5.1/storage/buffindexed/ovmethod.mk 2009-12-01 16:53:24.914809560
+0100
@@ -1,8 +1,8 @@
# This rule requires a compiler that supports -o with -c. Since it's normally
# used by developers, that should be acceptable.
-buffindexed/buffindexed_d.o: buffindexed/buffindexed.c
- $(CC) $(CFLAGS) -DBUFF_DEBUG -c -o $@ buffindexed/buffindexed.c
+buffindexed/buffindexed_d.$(EXTOBJ): buffindexed/buffindexed.c
+ $(LIBCC) $(CFLAGS) -DBUFF_DEBUG -c -o $@ buffindexed/buffindexed.c
=> Do you have a specific need for shared libraries?
--- inn-2.5.1/frontends/Makefile.pie 2009-10-12 20:24:04.000000000 +0200
+++ inn-2.5.1/frontends/Makefile 2009-10-13 21:51:38.000000000 +0200
@@ -85,7 +85,7 @@ ovdb_init: ovdb_init.o $(BOTH) ; $(
ovdb_monitor: ovdb_monitor.o $(BOTH) ; $(LINK) ovdb_monitor.o $(STORELIBS)
ovdb_server: ovdb_server.o $(BOTH) ; $(LINK) ovdb_server.o $(STORELIBS)
ovdb_stat: ovdb_stat.o $(BOTH) ; $(LINK) ovdb_stat.o $(STORELIBS)
-rnews: rnews.o $(LIBINN) ; $(LINK) rnews.o $(STORELIBS)
+rnews: rnews.o $(LIBINN) ; $(LINK) rnews.o -pie
$(STORELIBS)
sm: sm.o $(BOTH) ; $(LINK) sm.o $(STORELIBS)
=> Is it necessary to add "-pie" for rnews?
--- inn-2.4.1/Makefile.old 2004-12-13 13:09:57.000000000 +0100
+++ inn-2.4.1/Makefile 2004-12-13 14:29:56.625685696 +0100
@@ -91,9 +91,9 @@
directories:
@chmod +x support/install-sh
for D in $(INSTDIRS) ; do \
- support/install-sh $(OWNER) -m 0755 -d $(D)$$D ; \
+ support/install-sh $(OWNER) -m 0755 -d $(DESTDIR)/$$D ; \
done
- support/install-sh $(OWNER) -m 0750 -d $(D)$(PATHRUN)
+ support/install-sh $(OWNER) -m 0750 -d $(DESTDIR)/$(PATHRUN)
=> Be careful... Makefile.global mentions:
## DESTDIR should have a trailing slash, as the trailing
## slash is not added automatically (in case someone wants to add a prefix
## that isn't just a parent directory).
DESTDIR =
D = $(DESTDIR)
so your patch normally should not add "/". Anyway, as $(D) is $(DESTDIR),
the patch is not necessary.
--
Julien ?LIE
? ? Ne me dis pas que c'est cette poign?e de Gaulois d'en face qui
vous a mis dans cet ?tat !
? Il est vrai que j'ai ?t? frapp? moi-m?me par la force
persuasive de cette poign?e, amiral ! ? (Ast?rix)
------------------------------
Message: 2
Date: Fri, 24 May 2013 12:59:38 -0700
From: Russ Allbery <[email protected]>
To: [email protected]
Subject: Re: Odd issue with pod2man when building on Fedora build
server
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Julien ?LIE <[email protected]> writes:
> --- inn-2.5.2/storage/cnfs/cnfs.h.posix 2010-03-24 21:10:36.000000000
> +0100
> +++ inn-2.5.2/storage/cnfs/cnfs.h 2010-06-28 17:33:11.106804964 +0200
> @@ -18,4 +18,12 @@ void cnfs_printfiles(FILE *file, TOKEN t
> char *cnfs_explaintoken(const TOKEN token);
> void cnfs_shutdown(void);
>
> +/* Patch for POSIX */
> +
> +#ifndef MADV_SEQUENTAL
> + #ifdef POSIX_MADV_SEQENTIAL
> + #define MADV_SEQUITIAL POSIX_MADV_SEQUENTIAL
> + #endif
> +#endif
> +
> #endif
> => I will have a look at this one. Is there a specific architecture
> that needs this definition?
This change is only correct if the calls to madvise are also being changed
to posix_madvise. I'm not sure why one would do that, though. I suppose
we could do that more generally if posix_madvise is now more portable than
madvise or should be used by preference for portability, but that doesn't
seem like a change specific to a particular distribution.
This looks like a workaround for __USE_BSD not being defined during the
compilation, but INN should be built with GNU_SOURCE, which should enable
all the optional defines. It so happens that MADV_SEQUENTIAL and
POSIX_MADV_SEQUENTIAL have the same value right now on Linux, but I don't
think that's something we should properly rely upon.
> --- inn-2.5.1/storage/buffindexed/ovmethod.mk.shared 2009-12-01
> 16:50:37.174811272 +0100
> +++ inn-2.5.1/storage/buffindexed/ovmethod.mk 2009-12-01 16:53:24.914809560
> +0100
> @@ -1,8 +1,8 @@
> # This rule requires a compiler that supports -o with -c. Since it's
> normally
> # used by developers, that should be acceptable.
> -buffindexed/buffindexed_d.o: buffindexed/buffindexed.c
> - $(CC) $(CFLAGS) -DBUFF_DEBUG -c -o $@ buffindexed/buffindexed.c
> +buffindexed/buffindexed_d.$(EXTOBJ): buffindexed/buffindexed.c
> + $(LIBCC) $(CFLAGS) -DBUFF_DEBUG -c -o $@ buffindexed/buffindexed.c
> => Do you have a specific need for shared libraries?
This is probably a correct change regardless, though.
> --- inn-2.5.1/frontends/Makefile.pie 2009-10-12 20:24:04.000000000 +0200
> +++ inn-2.5.1/frontends/Makefile 2009-10-13 21:51:38.000000000 +0200
> @@ -85,7 +85,7 @@ ovdb_init: ovdb_init.o $(BOTH) ; $(
> ovdb_monitor: ovdb_monitor.o $(BOTH) ; $(LINK) ovdb_monitor.o
> $(STORELIBS)
> ovdb_server: ovdb_server.o $(BOTH) ; $(LINK) ovdb_server.o $(STORELIBS)
> ovdb_stat: ovdb_stat.o $(BOTH) ; $(LINK) ovdb_stat.o $(STORELIBS)
> -rnews: rnews.o $(LIBINN) ; $(LINK) rnews.o
> $(STORELIBS)
> +rnews: rnews.o $(LIBINN) ; $(LINK) rnews.o -pie
> $(STORELIBS)
> sm: sm.o $(BOTH) ; $(LINK) sm.o $(STORELIBS)
> => Is it necessary to add "-pie" for rnews?
I suspect this is because INN is setuid. However, I don't think there's
any reason not to build all of INN with -fPIE -pie if that's what you want
(and likewise with other hardening flags), so I would just put that into
CFLAGS during configure time.
> => Be careful... Makefile.global mentions:
> ## DESTDIR should have a trailing slash, as the trailing
> ## slash is not added automatically (in case someone wants to add a prefix
> ## that isn't just a parent directory).
> DESTDIR =
> D = $(DESTDIR)
> so your patch normally should not add "/". Anyway, as $(D) is $(DESTDIR),
> the patch is not necessary.
The comment is not really correct; the reason why the trailing slash isn't
required is because all the installation paths already start with /
because they're absolute paths determined by configure. (It is true that
our build system doesn't correctly handle builds where the installation
paths are relative paths, but I'm not sure that anyone would ever do
that.)
--
Russ Allbery ([email protected]) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 51, Issue 6
******************************************
