Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: Today's patches (Julien ?LIE)
2. Re: About the development of INN 1.5.1 through 1.8 (2.0)
(Julien ?LIE)
3. Re: Cast alignment warnings (Russ Allbery)
----------------------------------------------------------------------
Message: 1
Date: Sun, 24 May 2015 16:00:19 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Today's patches
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Russ,
>> I have just checked how these structs are currently used, to confirm
>> that it is OK to initialize all of them with 0.
>> The initialization is now done this way:
>> ARTHANDLE newart = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
>
>> I hope it is fine this way (that is to say "0" instead of "NULL"
>> for pointers is portable enough).
>
> Yup, that's fine. The only place you can't use 0 (or NULL) is when
> passing in a NULL pointer to a variadic function, in which case you need
> to explicitly cast it to the appropriate pointer type, such as (char *) 0.
> And that's because the compiler can't know the type of the argument.
> Here, the compiler knows, and can translate 0 without any difficulty.
OK, thanks for the explanation.
> A common C convention is to define some preprocessor symbol to the
> initializer for the data structure so that you can update it in only one
> place if you ever change the data structure (preferrably in the same
> header that defines the data structure). Like, for example,
> PTHREAD_MUTEX_INITIALIZER.
Adopted. It will indeed be easier to maintain.
--
Julien ?LIE
? ? Vous ramassez des champignons sans les conna?tre ?
? Et alors ? Ce n'est pas pour les manger mais pour les vendre. ?
------------------------------
Message: 2
Date: Sun, 24 May 2015 16:57:04 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: About the development of INN 1.5.1 through 1.8 (2.0)
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Russ,
>> We have tags for INN 1.5.1, INN 2.0, INN 2.1, INN 2.2.1 and all
>> released versions after 2.2.1.
>> I think 2.2.0 is revision 1724, according to the tar.gz, so we can
>> probably add it.
>
> That sounds like a good idea. We probably just missed making a tag
> at the time.
OK, I've just added the tag for INN 2.2.0.
>> Do we have the 1.x versions in our SVN after 1.5.1? I see in the
>> OLD section of ftp.isc.org there are 1.7.0, 1.7.1 and 1.7.2
>> versions after that one; the other versions seem to be only beta
>> versions (1.5.2pre1 and 1.6.0b1) so maybe INN 1.5.2 and 1.6.0 were
>> never released.
>
> I suspect that they were released but the tarballs were lost. We
> weren't as good at keeping releases around, and things were pretty
> chaotic back then. I also suspect there was no revision control in
> use at the time, and that scrappy imported 1.5.1 and then imported
> 1.8-current when building the initial CVS repository, but didn't have
> all the versions in between. But that's just a guess; I wasn't
> around at the time of the original creation of the CVS repository and
> am not sure.
>
> Everything that I was able to find when I started as primary
> maintainer is on the web site. More stuff is probably findable with
> sufficient archeology, but I'm not sure where it would be.
I will try to contact scrappy and maybe also Forrest to see if by chance
they have kept somewhere old tarballs of INN 1.x.
I will tell you in case I get news.
--
Julien ?LIE
? ? Vous ramassez des champignons sans les conna?tre ?
? Et alors ? Ce n'est pas pour les manger mais pour les vendre. ?
------------------------------
Message: 3
Date: Sun, 24 May 2015 08:45:42 -0700
From: Russ Allbery <[email protected]>
To: [email protected]
Subject: Re: Cast alignment warnings
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Julien ?LIE <[email protected]> writes:
> Should
> ovblock = (OVBLOCK *)((char *)addr + pagefudge);
> just be changed to
> ovblock = (void *)((char *)addr + pagefudge);
> in buffindexed/buffindexed.c:1667?
> It suppresses the warning.
Yup, that looks fine.
--
Russ Allbery ([email protected]) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 72, Issue 11
*******************************************
