Send inn-workers mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."


Today's Topics:

   1. Re: nnrpd given the same PID as innfeed (Richard Kettlewell)
   2. Re: nnrpd given the same PID as innfeed (Julien ?LIE)
   3. Re: nnrpd given the same PID as innfeed (Richard Kettlewell)
   4. Semaphore issue (Richard Kettlewell)


----------------------------------------------------------------------

Message: 1
Date: Fri, 19 Jun 2015 18:26:35 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Re: nnrpd given the same PID as innfeed
Message-ID: <[email protected]>
Content-Type: text/plain; charset="windows-1252"

On 18/06/15 18:19, Julien ?LIE wrote:
> I unfortunately have bad news about the fix of the issue.  I still see
> errors in my logs:

Oh dear.  In my defense it's hard to fix bugs without having managed to
reproduce them l-)

> Jun 18 06:33:55 news innd: nocem! exit 1 elapsed 57507 pid 22274
> Jun 18 06:33:55 news innd: inpaths! exit 1 elapsed 57507 pid 22272
> Jun 18 06:33:55 news innd: source-archive! exit 1 elapsed 57507 pid 22273
> Jun 18 06:47:02 news innd: innfeed! exit 1 elapsed 9120 pid 24910
> Jun 18 06:47:02 news innd: inpaths! exit 1 elapsed 9120 pid 24911
> Jun 18 09:23:07 news innd: innfeed! exit 1 elapsed 18485 pid 24910
> Jun 18 09:23:07 news innd: inpaths! exit 1 elapsed 18485 pid 24911
> Jun 18 12:06:49 news innd: innfeed! exit 1 elapsed 28306 pid 24910
> Jun 18 12:06:49 news innd: inpaths! exit 1 elapsed 28306 pid 24911
> Jun 18 14:42:35 news innd: inpaths! exit 1 elapsed 37653 pid 24911
> Jun 18 14:42:35 news innd: innfeed! exit 1 elapsed 37653 pid 24910
> Jun 18 17:21:00 news innd: inpaths! exit 1 elapsed 47157 pid 24911
> Jun 18 17:21:00 news innd: innfeed! exit 1 elapsed 47157 pid 24910

The repeated PIDs and consistently growing elasped time is the clue that
got me there.  Evidently it is revisiting the same PROCtable entries.

Patch attached.

ttfn/rjk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: procreap.patch
Type: text/x-patch
Size: 582 bytes
Desc: not available
URL: 
<https://lists.isc.org/pipermail/inn-workers/attachments/20150619/94babf8f/attachment-0001.bin>

------------------------------

Message: 2
Date: Fri, 19 Jun 2015 19:57:12 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: nnrpd given the same PID as innfeed
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed

Hi Richard,

> The repeated PIDs and consistently growing elasped time is the clue that
> got me there.  Evidently it is revisiting the same PROCtable entries.

OK, thanks.  Patch applied.
The previous one (for signal masking) should still be kept, shouldn't it?

I also instrumented innd/proc.c to log a line in news.notice when each 
function is entered.
I only have one log:

% grep PROC news.notice
Jun 19 13:59:57 news innd: PROCsetup called

After almost 6 hours of run, still no realloc or calls of PROCreap and 
PROCscan that change PROCtable.  And no "exit 1" errors.
I would have thought these functions were used more frequently.


Thanks again for your work on that issue!

-- 
Julien ?LIE

? Medicus dedit qui temporis morbo curam, Is plus remedii quam cutis
   sector dedit. ?


------------------------------

Message: 3
Date: Fri, 19 Jun 2015 20:01:49 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Re: nnrpd given the same PID as innfeed
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252

On 2015-06-19 18:57, Julien ?LIE wrote:
> Hi Richard,
> 
>> The repeated PIDs and consistently growing elasped time is the clue that
>> got me there.  Evidently it is revisiting the same PROCtable entries.
> 
> OK, thanks.  Patch applied.
> The previous one (for signal masking) should still be kept, shouldn't it?

Yes, I think so.

ttfn/rjk



------------------------------

Message: 4
Date: Sat, 20 Jun 2015 10:27:00 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Semaphore issue
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"

https://lists.isc.org/pipermail/inn-workers/2011-September/017933.html
> I believe there is a latent problem with our use of semaphores.
> I experienced again an exhaustion of available semaphores.

(Also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544457#30 )

The problem is quite simple: buffindexed deletes its shared memory
segment when there are no more users (i.e. when shm_nattch==0), but it
fails to delete the semaphore at the same time.

Patch attached.  'make check' no longer leaks semaphores.  I modified my
test rig to use buffindexed in one test so the code has been run in its
proper environment at least once!

ttfn/rjk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: semaphore.patch
Type: text/x-patch
Size: 1388 bytes
Desc: not available
URL: 
<https://lists.isc.org/pipermail/inn-workers/attachments/20150620/ac2b6929/attachment-0001.bin>

------------------------------

_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers

End of inn-workers Digest, Vol 73, Issue 8
******************************************

Reply via email to