Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. problem with logrotate logs (javi)
2. Re: problem with logrotate logs (Julien ?LIE)
3. Re: Clean 'make check' against gcc
-fsanitize=address,undefined (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Fri, 26 Jun 2015 15:30:50 +0200
From: "javi" <[email protected]>
To: <[email protected]>
Subject: problem with logrotate logs
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Hello
I have INN 2.5.4 and have problema with logrotate
each day the log rotation process is done I meet a series of errors as I put
below
[.]
logrotate_script: 2: kill: Usage: kill [-s sigspec | -signum | -sigspec]
[pid | job]... or kill -l [exitstatus]
error: error running non-shared postrotate script for
/var/log/news/innfeed.log of '/var/log/news/* '
cat: /injail/inn/run/inn.pid: No existe el archivo o el directorio
logrotate_script: 2: kill: Usage: kill [-s sigspec | -signum | -sigspec]
[pid | job]... or kill -l [exitstatus]
error: error running non-shared postrotate script for
/var/log/news/innfeed.log.1 of '/var/log/news/* '
cat: /injail/inn/run/inn.pid: No existe el archivo o el directorio
[.]
I use a compiled version, not the official version of ubuntu, as I prefer to
go to the last with the INN
This error generates logrotate me a lot of files in / var / log / news,
cleaning the last file that I had more than 250,000 files
you can help to correct this? I'm reviewing logrotate but I just saw where
the problem
regards
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150626/839e61e5/attachment-0001.html>
------------------------------
Message: 2
Date: Fri, 26 Jun 2015 17:12:34 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: problem with logrotate logs
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Hola javi,
> I have INN 2.5.4 and have problema with logrotate
>
> each day the log rotation process is done I meet a series of errors as I put
> below
>
> [?]
>
> logrotate_script: 2: kill: Usage: kill [-s sigspec | -signum | -sigspec] [pid
> | job]... or kill -l [exitstatus]
>
> error: error running non-shared postrotate script for
> /var/log/news/innfeed.log of '/var/log/news/* '
>
> cat: /injail/inn/run/inn.pid: No existe el archivo o el directorio
>
> logrotate_script: 2: kill: Usage: kill [-s sigspec | -signum | -sigspec] [pid
> | job]... or kill -l [exitstatus]
>
> error: error running non-shared postrotate script for
> /var/log/news/innfeed.log.1 of '/var/log/news/* '
>
> cat: /injail/inn/run/inn.pid: No existe el archivo o el directorio
What is the configuration of your logrotate script (usually in the
/etc/logrotate.d directory)?
Is it something like:
/var/log/news/news.crit {
monthly
rotate 2
olddir /var/log/news/old
missingok
postrotate
kill -HUP 'cat /var/run/inn.pid'
endscript
nocompress
}
Please be sure that the kill -HUP 'cat /var/run/inn.pid' line points to
the right file (I bet /injail/inn/run/inn.pid is marked in your
logrotate script, and that it is not the right place).
--
Julien ?LIE
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20150626/874876b3/attachment-0001.html>
------------------------------
Message: 3
Date: Fri, 26 Jun 2015 20:23:41 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Clean 'make check' against gcc
-fsanitize=address,undefined
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Richard,
>> The current code is:
>> now = (tv.tv_sec - base.tv_sec) * 1000;
>> now += (tv.tv_usec - base.tv_usec) / 1000;
>
> That doesn't help. In the current code the multiplication is done in
> the signed type. If it overflows (as it will after a few weeks, on
> 32-bit platforms) then we are already into undefined behavior (C99 s6.5#5).
Then, so as to prevent overflows, maybe we should call TMRsummary() more
often, or force it when the timer is near to overflowing. I believe the
issue only appears when innconf->timer is 0 because calls to
TMRsummary() are not done in this configuration.
Oh, I see that the default value for innconf->timer is 0 whereas the
inn.conf documentation indicates that "enabling this is highly
recommended". Maybe we could change the default value for INN 2.6.0!
Suggestion: 600s (10mn).
If set to 0, maybe we could force the log anyway when it reaches 42
days? It won't do much harm, and it will prevent these overflows.
Any thought about that?
>> If I follow your suggestion with tv=2,2s and base=1,4s:
>>
>> now = (unsigned long)(tv.tv_sec - base.tv_sec) * 1000u;
>> usec = tv.tv_usec - base.tv_usec; /* maybe -ve */
>> msec = usec / 1000; /* still maybe -ve */
>> now += (unsigned long)msec;
>> I believe it would result in:
>> now = 1000 + (-200+UINT_MAX+1) which would overflow because
>> of the negative msec being converted to unsigned, instead of:
>
> Overflow behavior for unsigned types (including conversion of negative
> values to unsigned types) is defined: the result is the residue modulo
> 2^n (C99 s6.2.5#9). The result with the patch is therefore 800.
OK, thanks.
Patch applied.
Do you believe something similar should be done for the computation of
OVERartcheck and OVERtime in nnrpd code?
and statistics->busy as well as total in backends/overchan.c?
and STATUSgettime() in innd/status.c?
--
Julien ?LIE
? Le temps, c'est des sesterces. ? (Coquelus)
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 73, Issue 14
*******************************************
