Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Odd diagnostic (Richard Kettlewell)
2. Re: Odd diagnostic (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Sun, 28 Jun 2015 13:06:06 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Odd diagnostic
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Something I noticed during testing; see attached. I've not had time to
investigate this but I think it must indicate a bug in nnrpd's article
parser.
ttfn/rjk
-------------- next part --------------
richard@deodand:~/src/inn-test$ telnet localhost 1119
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
200 test.anjou.terraraq.org.uk InterNetNews server INN 2.6.0 (20150628
prerelease) ready (transit mode)
mode reader
200 test.anjou.terraraq.org.uk InterNetNews NNRP server INN 2.6.0 (20150628
prerelease) ready (posting ok)
post
340 Ok, recommended message-ID <[email protected]>
Subject: test
Newsgroups:
From: [email protected]
test message
.
441 No valid newsgroups in "From: [email protected]"
quit
205 Bye!
Connection closed by foreign host.
------------------------------
Message: 2
Date: Mon, 29 Jun 2015 13:52:33 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Odd diagnostic
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252
Hi Richard,
> Something I noticed during testing; see attached. I've not had time to
> investigate this but I think it must indicate a bug in nnrpd's article
> parser.
Oh, yes, indeed.
Continuation lines in headers are not properly parsed. The fact that the
first character in the next line is whitespace was not in the condition.
I believe the following patch fixes the issue:
--- post.c (r?vision 9898)
+++ post.c (copie de travail)
@@ -226,8 +226,10 @@
hp->Value = &p[hp->Size + 1];
/* '\r\n' is replaced with '\n', and unnecessary to consider
* '\r'. */
- for (q = &p[hp->Size + 1]; ISWHITE(*q) || *q == '\n'; q++)
+ for (q = &p[hp->Size + 1]; ISWHITE(*q)
+ || (*q == '\n' && ISWHITE(q[1])) ; q++)
continue;
hp->Body = q;
break;
}
"Newsgroups:\r\n"
POST
340 Ok, recommended message-ID <[email protected]>
Subject: test
Newsgroups:
From: [email protected]
test message
.
441 Can't parse Newsgroups: header
"Newsgroups: \r\n"
POST
340 Ok, recommended message-ID <[email protected]>
Subject: test
Newsgroups:
From: [email protected]
test message
.
441 Can't parse Newsgroups: header
"Newsgroups: a\r\n"
POST
340 Ok, recommended message-ID <[email protected]>
Subject: test
Newsgroups: a
From: [email protected]
test message
.
441 No valid newsgroups in "a"
"Newsgroups:\r\n a\r\n"
POST
340 Ok, recommended message-ID <[email protected]>
Subject: test
Newsgroups:
a
From: [email protected]
test message
.
441 No valid newsgroups in "a"
"Newsgroups:\r\n \r\n"
POST
340 Ok, recommended message-ID <[email protected]>
Subject: test
Newsgroups:
From: [email protected]
test message
.
441 Can't parse Newsgroups: header
Seems to parse correctly now.
--
Julien ?LIE
? Le temps, c'est des sesterces. ? (Coquelus)
------------------------------
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
End of inn-workers Digest, Vol 73, Issue 16
*******************************************
