Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: Clang 3.9 report (Julien ?LIE)
2. Re: Clang 3.9 report (Russ Allbery)
----------------------------------------------------------------------
Message: 1
Date: Fri, 26 Aug 2016 21:18:30 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Clang 3.9 report
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi The Doctor,
> lib/getaddrinfo-t.c:265:13: warning: logical not is only applied to the left
> hand side of this comparison [-Wlogical-not-parentheses]
> if (!strcmp(ai->ai_canonname, first->ai_canonname) == 0) {
Thanks for the report.
I would suggest the following change:
--- getaddrinfo-t.c (r?vision 10040)
+++ getaddrinfo-t.c (copie de travail)
@@ -262,7 +262,7 @@
is_int(0, saddr->sin_port, "...port is 0");
first = ai;
for (found = 0; ai != NULL; ai = ai->ai_next) {
- if (!strcmp(ai->ai_canonname, first->ai_canonname) == 0) {
+ if (strcmp(ai->ai_canonname, first->ai_canonname) != 0) {
ok(0, "...canonname matches");
break;
}
Russ, could you take it into account in rra-c-util?
Thanks,
--
Julien ?LIE
? Tu dis que tu aimes les fleurs et tu leur coupes la queue, tu dis
que tu aimes les chiens et tu leur mets une laisse, tu dis que tu
aimes les oiseaux et tu les mets en cage, tu dis que tu m'aimes alors
moi j'ai peur. ? (Jean Cocteau)
------------------------------
Message: 2
Date: Fri, 26 Aug 2016 14:33:32 -0700
From: Russ Allbery <[email protected]>
To: [email protected]
Subject: Re: Clang 3.9 report
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Julien ?LIE <[email protected]> writes:
> Hi The Doctor,
>> lib/getaddrinfo-t.c:265:13: warning: logical not is only applied to the left
>> hand side of this comparison [-Wlogical-not-parentheses]
>> if (!strcmp(ai->ai_canonname, first->ai_canonname) == 0) {
> Thanks for the report.
> I would suggest the following change:
> --- getaddrinfo-t.c (r?vision 10040)
> +++ getaddrinfo-t.c (copie de travail)
> @@ -262,7 +262,7 @@
> is_int(0, saddr->sin_port, "...port is 0");
> first = ai;
> for (found = 0; ai != NULL; ai = ai->ai_next) {
> - if (!strcmp(ai->ai_canonname, first->ai_canonname) == 0) {
> + if (strcmp(ai->ai_canonname, first->ai_canonname) != 0) {
> ok(0, "...canonname matches");
> break;
> }
> Russ, could you take it into account in rra-c-util?
Yup, done. Thanks!
--
Russ Allbery ([email protected]) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 86, Issue 7
******************************************
