Send inn-workers mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."


Today's Topics:

   1. Re: INN 2.6.1 release candidate (Julien ?LIE)


----------------------------------------------------------------------

Message: 1
Date: Wed, 9 Nov 2016 21:28:58 +0100
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: INN 2.6.1 release candidate
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed

Hi David,

> [dbz.c:1734]: (warning) Comparison of a boolean expression with an
> integer other
>  than 0 or 1.
> [dbz.c:1742]: (warning) Comparison of a boolean expression with an
> integer other
>  than 0 or 1.
>
> If a function returns bool, then comparisons with less than zero don't
> make much sense. I don't know why gcc doesn't complain about this.

Good catch!
As you say, strange that gcc doesn't see that (-Wbool-compare is enabled 
by -Wall).

Will be fixed in the final 2.6.1 release.

--- lib/dbz.c   (r?vision 10090)
+++ lib/dbz.c   (copie de travail)
@@ -1731,7 +1731,7 @@
      if (initialize) {
        RemoveDBZ(history);
        gettimeofday(&start, NULL);
-       if (dbzfresh(history, dbzsize(size)) < 0) {
+       if (!dbzfresh(history, dbzsize(size))) {
            fprintf(stderr, "cant dbzfresh %s\n", history);
            exit(1);
        }
@@ -1739,7 +1739,7 @@
        printf("dbzfresh: %d msec\n", timediffms(start, end));
      } else {
        gettimeofday(&start, NULL);
-       if (dbzinit(history) < 0) {
+       if (!dbzinit(history)) {
            fprintf(stderr, "cant dbzinit %s\n", history);
            exit(1);
        }

-- 
Julien ?LIE

? Ce que j'aime chez vous, c'est que vous savez jusqu'o? on va trop
   loin. ? (Cocteau)


------------------------------

Subject: Digest Footer

_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers

------------------------------

End of inn-workers Digest, Vol 89, Issue 3
******************************************

Reply via email to