Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: Relaxing a few checks (Julien ?LIE)
2. Re: Relaxing a few checks (Kamil =?iso-8859-2?Q?Jo=F1ca?=)
----------------------------------------------------------------------
Message: 1
Date: Sat, 1 Apr 2017 16:41:18 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Relaxing a few checks
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252
Hi Kamil,
> I wrote another patch.
> This collect empty header names, and if there is any, add
> X-Mailpost-Empty-Hdrs field (with collected names) to post.
It is indeed another solution, that has the advantage of keeping
trace of the removal of empty header fields.
In your patch:
$emptyhdrs=join(", " , @emptyHdrs);
while (length ($emptyhdrs) >975 ){ #998-length "X-Mailpost-Empty-Hdrs: ")
$emptyhdrs=substr($emptyhdrs,0,rindex($emptyhdrs,","));
}
Instead of stripping a possible too long line, why not keep all
the header field names and use folding?
For instance with:
$emptyhdrs=join("\n\t" , @emptyHdrs);
I think it would make the code simpler, and permit to keep everything.
Of course, if you fear one may inject overlong header field names,
it is possible to retain only "normal" ones with a truncation or
an additional condition. For instance:
push (@emptyHdrs, substr($1, 0, 975));
or
push (@emptyHdrs, $1) if length($1) < 975;
when filling the array. Maybe the truncation is the better solution.
--
Julien ?LIE
? Mais pourquoi courent-ils si vite ? Pour gagner du temps ! Comme
le temps, c'est de l'argent? plus ils courent vite, plus ils en
gagnent. ? (Raymond Devos)
------------------------------
Message: 2
Date: Sat, 01 Apr 2017 18:05:52 +0200
From: [email protected] (Kamil =?iso-8859-2?Q?Jo=F1ca?=)
To: [email protected]
Subject: Re: Relaxing a few checks
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-8859-2
Julien ?LIE <[email protected]> writes:
> Hi Kamil,
>
>> I wrote another patch.
>> This collect empty header names, and if there is any, add
>> X-Mailpost-Empty-Hdrs field (with collected names) to post.
>
> It is indeed another solution, that has the advantage of keeping
> trace of the removal of empty header fields.
>
>
> In your patch:
>
> $emptyhdrs=join(", " , @emptyHdrs);
> while (length ($emptyhdrs) >975 ){ #998-length "X-Mailpost-Empty-Hdrs: ")
> $emptyhdrs=substr($emptyhdrs,0,rindex($emptyhdrs,","));
> }
>
> Instead of stripping a possible too long line, why not keep all
> the header field names and use folding?
Good point. I think it would be better.
>
> For instance with:
>
> $emptyhdrs=join("\n\t" , @emptyHdrs);
You re right .
[..about very long header names...]
I think it is so rare, so can be handled manually.
KJ
--
http://wolnelektury.pl/wesprzyj/teraz/
"Uchodzi? za idiot? w oczach kretyna - to rozkosz dla smakosza"
[Georges Courteline]
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 94, Issue 1
******************************************
