Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: modernize innreport HTML (Julien ?LIE)
2. Re: modernize innreport HTML (Richard Kettlewell)
----------------------------------------------------------------------
Message: 1
Date: Sun, 24 May 2020 10:27:45 +0200
From: Julien ?LIE <[email protected]>
To: [email protected], Richard Kettlewell <[email protected]>
Subject: Re: modernize innreport HTML
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Richard,
> The current design is broken when served over HTTPS or when the
> webserver has a content security policy. The attached patch fixes both
> issues.
Here are the 2 patches I've come up with, following your initial
suggestion and subsequent discussions in the mailing-list:
https://inn.eyrie.org/trac/changeset/10368 (remove W3C links)
https://inn.eyrie.org/trac/changeset/10374 (CSS externalization)
I've notably added a comment, for future references, to keep old CSS
definitions for backward compatibility with previously generated reports
(in case we change HTML structure or style names in future versions).
Also, automatic generation of innreport.css does not occur if the user
has a specific CSS of the same name (he would otherwise loose it).
Besides, I suggest a change in innreport version numbers. It has been
"innreport 3.1.0" for a long time, even though modifications were
carried. A wording like "innreport from INN 2.6.4" (incrementing with a
new release) makes it clearer:
https://inn.eyrie.org/trac/changeset/10371
If you have any comment, do not hesitate to tell.
I'll commit these patches in a few days to the stable branch (for INN
2.6.4) if that's OK for everyone.
--
Julien ?LIE
??Vous ?tes mon lion, superbe et g?n?reux.?? (Hugo, _Hernani_)
------------------------------
Message: 2
Date: Sun, 24 May 2020 12:09:21 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Re: modernize innreport HTML
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
On 24/05/2020 09:27, Julien ?LIE wrote:
> Here are the 2 patches I've come up with, following your initial
> suggestion and subsequent discussions in the mailing-list:
>
> ? https://inn.eyrie.org/trac/changeset/10368 (remove W3C links)
> ? https://inn.eyrie.org/trac/changeset/10374 (CSS externalization)
>
> I've notably added a comment, for future references, to keep old CSS
> definitions for backward compatibility with previously generated reports
> (in case we change HTML structure or style names in future versions).
> Also, automatic generation of innreport.css does not occur if the user
> has a specific CSS of the same name (he would otherwise loose it).
>
>
> Besides, I suggest a change in innreport version numbers.? It has been
> "innreport 3.1.0" for a long time, even though modifications were
> carried.? A wording like "innreport from INN 2.6.4" (incrementing with a
> new release) makes it clearer:
>
> ? https://inn.eyrie.org/trac/changeset/10371
>
>
> If you have any comment, do not hesitate to tell.
> I'll commit these patches in a few days to the stable branch (for INN
> 2.6.4) if that's OK for everyone.
All looks good to me!
ttfn/rjk
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 119, Issue 5
*******************************************
