Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: docs/pod test failures (Julien ?LIE)
2. Towards INN 2.6.4 release (Julien ?LIE)
3. Re: docs/pod test failures (Bo Lindbergh)
4. Re: Towards INN 2.6.4 release (Bo Lindbergh)
5. Re: Towards INN 2.6.4 release (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Tue, 13 Oct 2020 21:12:45 +0200
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: docs/pod test failures
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Bo,
> Is there some reason for tests/docs/pod.t using /usr/bin/perl
> rather than the perl found by configure? I'm getting these
> weird test failures that go away if I manually edit tests/docs/pod.t
> to have the right path.
No particular reason. Just a bug! I forgot to add the magic to change
Perl interpreter when integrating this script into our test suite.
Thanks for having caught it. Fixed upstream:
https://inn.eyrie.org/trac/changeset/10389/
--
Julien ?LIE
????I see the world didn't end yesterday.
? Are you sure??? (Alan Moore, _Watchmen_)
------------------------------
Message: 2
Date: Tue, 13 Oct 2020 21:19:43 +0200
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Towards INN 2.6.4 release
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi all,
Our last release dates back to 2 years (time goes fast!). Not many
changes, no major fixes but a few minor improvements or bug fixes.
I believe it is worthwhile releasing INN 2.6.4 for instance in early 2021.
Any patch you would like to include?
Any annoying bug you're facing?
--
Julien ?LIE
????I see the world didn't end yesterday.
? Are you sure??? (Alan Moore, _Watchmen_)
------------------------------
Message: 3
Date: Tue, 13 Oct 2020 22:30:59 +0200
From: Bo Lindbergh <[email protected]>
To: [email protected]
Subject: Re: docs/pod test failures
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Quoth <[email protected]>:
>
> No particular reason. Just a bug! I forgot to add the magic to change Perl
> interpreter when integrating this script into our test suite.
There are more cases of hard-coded /usr/bin/perl that might need
the fixscript treatment too:
contrib/mkbuf
contrib/analyze-traffic.pl
contrib/authmysql
innfeed/testListener.pl
support/mkchangelog
support/mkmanifest
tests/data/overview/munge-data
I'll leave this to somebody who's more familiar with the codebase than I am...
/Bo Lindbergh
------------------------------
Message: 4
Date: Tue, 13 Oct 2020 23:16:06 +0200
From: Bo Lindbergh <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: Towards INN 2.6.4 release
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Quoth Julien ?LIE <[email protected]>:
> Any patch you would like to include?
> Any annoying bug you're facing?
Apple's rash decision to add -Werror to the default settings
for their compilers causes some headaches.
Examples from INN include the mmap tests calling umask(2) without including
<sys/stat.h> and close(2) without including <unistd.h>. The consequent
compilation errors (spuriously) undefine HAVE_MMAP.
A patch for these is attached.
Additionally, Apple has the same kind of problem in their own system headers!
Example: the definition of SUN_LEN has a call to strlen(3), but <sys/un.h>
doesn't include <string.h>.
I'll fire off a bug report to Apple once I've collected as many of these
as I can find, because you really shouldn't have to do
./configure CFLAGS=-Wno-error=all
just to get a correct configuration.
/Bo Lindbergh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: misconfig.diff
Type: application/octet-stream
Size: 1022 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20201013/3d60d5da/attachment-0001.obj>
------------------------------
Message: 5
Date: Tue, 13 Oct 2020 23:40:37 +0200
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: Towards INN 2.6.4 release
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Bo,
> Examples from INN include the mmap tests calling umask(2) without including
> <sys/stat.h> and close(2) without including <unistd.h>.? The consequent
> compilation errors (spuriously) undefine HAVE_MMAP.
>
> A patch for these is attached.
Thanks, included.
Russ, this one is for rra-c-util:
--- inn-2.6.3/m4/socket.m4 2019-02-07 16:02:22.000000000 +0100
+++ inn-hacked/m4/socket.m4 2020-10-12 23:25:00.000000000 +0200
@@ -39,6 +39,7 @@
AC_DEFUN([_INN_FUNC_GETADDRINFO_ADDRCONFIG_SOURCE], [[
#include <netdb.h>
#include <stdio.h>
+#include <string.h>
#include <sys/types.h>
#include <sys/socket.h>
Note that I've added "#if HAVE_UNISTD_H" checks to your proposal.
Index: lib/getpagesize.c
===================================================================
--- lib/getpagesize.c (r?vision 10387)
+++ lib/getpagesize.c (copie de travail)
@@ -8,7 +8,9 @@
*/
#include "config.h"
-#include <unistd.h>
+#if HAVE_UNISTD_H
+# include <unistd.h>
+#endif
int
getpagesize(void)
Index: m4/mmap.m4
===================================================================
--- m4/mmap.m4 (r?vision 10387)
+++ m4/mmap.m4 (copie de travail)
@@ -26,8 +26,12 @@
define([_INN_FUNC_MMAP_SOURCE],
[AC_LANG_SOURCE([[
#include <fcntl.h>
+#include <stdlib.h>
#include <sys/mman.h>
-#include <stdlib.h>
+#include <sys/stat.h>
+#if HAVE_UNISTD_H
+# include <unistd.h>
+#endif
int
main()
@@ -87,10 +91,14 @@
dnl Source used by INN_FUNC_MMAP_NEEDS_MSYNC.
define([_INN_FUNC_MMAP_NEEDS_MSYNC_SOURCE],
[AC_LANG_SOURCE([[
-#include <sys/types.h>
#include <fcntl.h>
+#include <stdlib.h>
#include <sys/mman.h>
-#include <stdlib.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#if HAVE_UNISTD_H
+# include <unistd.h>
+#endif
int
main()
Index: storage/cnfs/cnfs-private.h
===================================================================
--- storage/cnfs/cnfs-private.h (r?vision 10387)
+++ storage/cnfs/cnfs-private.h (copie de travail)
@@ -7,7 +7,9 @@
#define CNFS_PRIVATE_H 1
#include <sys/types.h>
-#include <unistd.h>
+#if HAVE_UNISTD_H
+# include <unistd.h>
+#endif
#define _PATH_CYCBUFFCONFIG "cycbuff.conf"
--
Julien ?LIE
????I see the world didn't end yesterday.
? Are you sure??? (Alan Moore, _Watchmen_)
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 124, Issue 2
*******************************************
