Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: ovsqlite (Julien ?LIE)
2. Re: Please generate the ChangeLog file also for snapshots
(Marco d'Itri)
3. Re: ovsqlite (Bo Lindbergh)
4. Re: ovsqlite (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Sun, 3 Jan 2021 23:30:18 +0100
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: ovsqlite
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Bo,
>> If I do not take into account the first 2 warnings, and manually
>> use sqlite3_prepare_v2, the remaining of the build works fine with
>> SQLite 3.8.7.1 from Debian Jessie. Good news!
>
> The minimum version requirement is based only on SQL language
> features. I ought to download SQLite 3.8.2 and test against it at
> some point.
Just tried to build INN with SQLite 3.8.2 and it appears that
sqlite-helper uses sqlite3_malloc64() which is a function added only in
SQLite 3.8.7.
I therefore suggest to require SQLite 3.8.7.
To silent a GCC warning, if you're OK with that, I also suggest to add
"return 1" at the end of the main function (defined to return an int):
--- storage/ovsqlite/ovsqlite-server.c (r?vision 10477)
+++ storage/ovsqlite/ovsqlite-server.c (copie de travail)
@@ -2162,6 +2162,8 @@
close_db();
if (pidfile)
unlink(pidfile);
+
+ return 1;
}
#else /* ! HAVE_SQLITE3 */
--
Julien ?LIE
? Donner un sens plus pur aux mots de la tribu. ? (St?phane Mallarm?)
------------------------------
Message: 2
Date: Mon, 4 Jan 2021 02:51:51 +0100
From: Marco d'Itri <[email protected]>
To: Julien ?LIE <[email protected]>
Cc: [email protected]
Subject: Re: Please generate the ChangeLog file also for snapshots
Message-ID: <X/[email protected]>
Content-Type: text/plain; charset=utf-8
On Nov 24, Julien ?LIE <[email protected]> wrote:
> In the no_unused_python patch, when Python filter files are not found,
> logs are changed from error to notice:
>
> https://salsa.debian.org/md/inn2/-/raw/master/debian/patches/no_unused_python
> syslog(L_NOTICE, "python is not initialized");
> syslog(L_NOTICE, "%s not installed", path);
>
> Shouldn't the same level (notice) be also used for Perl filters?
> In lib/perl.c, PERLsetup logs it as en error:
>
> syslog(L_ERROR,"SERVER perl loading %s failed: %s",
> startupfile, SvPV(errsv, PL_na));
No, because this message is used to report syntax errors in the Perl
code.
If you want to support Perl-less operations then you should add an
access() check like the Python one.
--
ciao,
Marco
------------------------------
Message: 3
Date: Mon, 4 Jan 2021 11:36:34 +0100
From: Bo Lindbergh <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: ovsqlite
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Quoth Julien ?LIE <[email protected]>:
>
> Just tried to build INN with SQLite 3.8.2 and it appears that sqlite-helper
> uses sqlite3_malloc64() which is a function added only in SQLite 3.8.7.
> I therefore suggest to require SQLite 3.8.7.
Those uses allocate an error message buffer. I'd say it's a safe
assumption that the size won't exceed INT_MAX, so switching to the old
sqlite3_malloc function should be OK.
> To silent a GCC warning, if you're OK with that, I also suggest to add
> "return 1" at the end of the main function (defined to return an int):
That's a clean exit, so it should return 0.
Patch for both issues attached.
/Bo Lindbergh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: delta5.diff.gz
Type: application/x-gzip
Size: 424 bytes
Desc: not available
URL:
<https://lists.isc.org/pipermail/inn-workers/attachments/20210104/6adde0a3/attachment-0001.bin>
------------------------------
Message: 4
Date: Mon, 4 Jan 2021 12:27:47 +0100
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Re: ovsqlite
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Bo,
>> Just tried to build INN with SQLite 3.8.2 and it appears that
>> sqlite-helper uses sqlite3_malloc64() which is a function added only in
>> SQLite 3.8.7.
>> I therefore suggest to require SQLite 3.8.7.
>
> Those uses allocate an error message buffer. I'd say it's a safe
> assumption that the size won't exceed INT_MAX, so switching to the
> old sqlite3_malloc function should be OK.
OK.
>> To silent a GCC warning, if you're OK with that, I also suggest to add
>> "return 1" at the end of the main function (defined to return an int):
>
> That's a clean exit, so it should return 0.
Oh, yes, of course!
> Patch for both issues attached.
Thanks, just applied.
--
Julien ?LIE
??Donner un sens plus pur aux mots de la tribu.?? (St?phane Mallarm?)
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 127, Issue 2
*******************************************
