Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. INN 2.6.4 util/inndf test 6 gives different result on ppc64le
on Fedora (Dominik 'Rathann' Mierzejewski)
2. Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora (Julien ?LIE)
3. Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora (Dominik 'Rathann' Mierzejewski)
4. Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora (Julien ?LIE)
5. Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora (Dominik 'Rathann' Mierzejewski)
6. Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora (Julien ?LIE)
7. Re: [PATCH] drop unused filterPath (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Tue, 16 Feb 2021 15:32:40 +0100
From: Dominik 'Rathann' Mierzejewski <[email protected]>
To: [email protected]
Subject: INN 2.6.4 util/inndf test 6 gives different result on ppc64le
on Fedora
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hi all,
while preparing an update to Fedora inn package (to 2.6.4),
I encountered this test failure on ppc64le only:
[...]
util/inndf..............FAILED 6
Closer inspection shows:
[mockbuild@e18bd93d051b44ce8fb7851e05850239 tests]$
LD_LIBRARY_PATH=/builddir/build/BUILDROOT/inn-2.6.4-1.fc35.ppc64le/usr/lib64
./runtests util/inndf -o
6
ok 1
ok 2
ok 3
ok 4
ok 5
3.33% overview space used
not ok 6
[mockbuild@e18bd93d051b44ce8fb7851e05850239 tests]$
I worked around this by patching the expected result to the above value
on ppc64le only, but perhaps there's a better solution? Could this be
related to the fact that ppc64le uses 64k page size instead of 4k?
Example failed build (on Fedora 34 branch):
https://koji.fedoraproject.org/koji/taskinfo?taskID=62075080
(check build.log)
Regards,
Dominik
--
Fedora https://getfedora.org | RPM Fusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
------------------------------
Message: 2
Date: Tue, 16 Feb 2021 15:45:22 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Dominik,
> while preparing an update to Fedora inn package (to 2.6.4),
> I encountered this test failure on ppc64le only:
> [...]
> util/inndf..............FAILED 6
> 3.33% overview space used
> not ok 6
>
> I worked around this by patching the expected result to the above value
> on ppc64le only, but perhaps there's a better solution? Could this be
> related to the fact that ppc64le uses 64k page size instead of 4k?
Certainly!
The failing test is the one for "inndf -o". I've fixed a bug in INN
2.6.4 in the output of this command for buffindexed: it was always
returning an integer instead of a 2-decimal number.
That's wht in INN 2.6.3 and earlier, the test suite was looking for
"3.00% overview space used". I changed the test suite to look for
"3.17% overview space used", which was the number in a few systems I
used for testing. Unfortunately, I did not test that on ppc64le before
the release. It was a last-minute change, occurring between by whole
portability testing (including ppc64le) and the release, sorry.
You can grab the following patch for your packaging for Fedora, which
checks the inndf result against an integer (00 as decimals):
https://inn.eyrie.org/trac/changeset/10541
--
Julien ?LIE
??Les amis de la v?rit? sont ceux qui la cherchent, et non ceux qui se
vantent de l'avoir trouv?e.?? (Condorcet)
------------------------------
Message: 3
Date: Tue, 16 Feb 2021 16:18:25 +0100
From: Dominik 'Rathann' Mierzejewski <[email protected]>
To: [email protected]
Subject: Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-8859-1
Hello, Julien.
On Tuesday, 16 February 2021 at 15:45, Julien ?LIE wrote:
[...]
> You can grab the following patch for your packaging for Fedora, which
> checks the inndf result against an integer (00 as decimals):
> https://inn.eyrie.org/trac/changeset/10541
That works without making the patch conditional on ppc64le arch, thanks!
Regards,
Dominik
--
Fedora https://getfedora.org | RPM Fusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
------------------------------
Message: 4
Date: Tue, 16 Feb 2021 22:16:24 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Dominik,
> That works without making the patch conditional on ppc64le arch, thanks!
As for the INN 2.6.4 Fedora package, I think you can drop
inn-2.6.4-pie.patch because it is now enforced by default for the whole
build. I've checked in the Fedora build logs, that it is OK:
checking if gcc supports -fPIE... yes
checking if gcc supports -pie for linking... yes
Every program built has that flag, and both rnews and innd have it twice :)
Description of the inn package needs being reviewed:
"INN (InterNetNews) is a complete system for serving Usenet news and/or
private newsfeeds. INN includes innd, an NNTP (NetNews Transport
Protocol) server, and nnrpd, a newsreader that is spawned for each
client. Both innd and nnrpd vary slightly from the NNTP protocol, but
not in ways that are easily noticed. Install the inn package if you need
a complete system for serving and reading Usenet news. You may also need
to install inn-devel, if you are going to use a separate program which
interfaces to INN, like newsgate or tin."
=> NNTP means NetNews Transfer Protocol (not Transport)
=> nnrpd is not a newsreader but also a news server that handles
connections from news readers
=> should it be mentioned that innd and nnrpd vary slightly from the
NNTP protocol? it is *very very* slightly :-)
=> "a complete system for serving and reading Usenet news" => for
posting, injecting, relaying and serving, but not reading AFAIK or I am
really missing something, or you call pullnews a reading agent :-)
inn-devel package:
I've looked at the installed files. These two ones for INN Perl modules
should not be in inn-devel but in inn directly:
/usr/share/man/man3/INN::Config.3pm.gz
/usr/share/man/man3/INN::Utils::Shlock.3pm.gz
Also, maybe clibrary.h and config.h should not be in inn-devel but in inn.
inn package:
A few files ending with ".in" are mentioned in
/usr/share/doc/inn/samples as installed files; they should be excluded.
--
Julien ?LIE
??Les amis de la v?rit? sont ceux qui la cherchent, et non ceux qui se
vantent de l'avoir trouv?e.?? (Condorcet)
------------------------------
Message: 5
Date: Tue, 16 Feb 2021 23:06:42 +0100
From: Dominik 'Rathann' Mierzejewski <[email protected]>
To: [email protected]
Subject: Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-8859-1
Hi, Julien!
On Tuesday, 16 February 2021 at 22:16, Julien ?LIE wrote:
> Hi Dominik,
>
> > That works without making the patch conditional on ppc64le arch, thanks!
>
> As for the INN 2.6.4 Fedora package, I think you can drop
> inn-2.6.4-pie.patch because it is now enforced by default for the whole
> build. I've checked in the Fedora build logs, that it is OK:
>
> checking if gcc supports -fPIE... yes
> checking if gcc supports -pie for linking... yes
>
> Every program built has that flag, and both rnews and innd have it twice :)
I'll drop it.
> Description of the inn package needs being reviewed:
[...]
The description was written by previous maintainers. I'll update it
according to your suggestions.
> inn-devel package:
> I've looked at the installed files. These two ones for INN Perl modules
> should not be in inn-devel but in inn directly:
> /usr/share/man/man3/INN::Config.3pm.gz
> /usr/share/man/man3/INN::Utils::Shlock.3pm.gz
I'll move them, thanks.
> Also, maybe clibrary.h and config.h should not be in inn-devel but in inn.
I'll move those as well.
> inn package:
> A few files ending with ".in" are mentioned in /usr/share/doc/inn/samples as
> installed files; they should be excluded.
Will do.
Thanks for the thorough review!
Regards,
Dominik
--
Fedora https://getfedora.org | RPM Fusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
------------------------------
Message: 6
Date: Wed, 17 Feb 2021 07:32:52 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: INN 2.6.4 util/inndf test 6 gives different result on
ppc64le on Fedora
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Dominik,
>> Description of the inn package needs being reviewed:
>
> The description was written by previous maintainers. I'll update it
> according to your suggestions.
Thanks!
>> Also, maybe clibrary.h and config.h should not be in inn-devel but in inn.
>
> I'll move those as well.
My wording was not right. They should not be included in the inn
package either, just removed and not shipped. They are internal header
files used for compiling only.
> Thanks for the thorough review!
You're welcome!
Comparing with the Debian files (lists at the end of
<https://packages.debian.org/sid/inn2> ;
<https://packages.debian.org/sid/inn2-dev> and
<https://packages.debian.org/sid/inn2-inews>), other suggestions would be:
- ship uwildmat.3 man page with inn and not inn-devel (I've just
confirmed the reason with Marco, who remembered me that they are
explicitly in the main Debian package because they document how
wildmat works, which is used in configuration files);
- ship more files with inews? (see the list in the Debian package,
including configuration files, and also rnews)
Thanks again for your work on the Fedora packaging,
--
Julien ?LIE
??Vina bibant homines, animantia cetera fontes.??
------------------------------
Message: 7
Date: Wed, 17 Feb 2021 07:41:18 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: [PATCH] drop unused filterPath
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Dominik,
>> I have some more patches from Fedora package lined up for
>> submission. I'll post them here as time permits. I'll have to dig up the
>> rationale behind their existence, too, as they were created by previous
>> maintainers.
I think INN 2.6.4 includes all the patches that are meant to be merged
upstream. Do not hesitate to tell if you think other changes should
also be merged.
> FYI, we once discussed them (in 2013, long time ago already!) in the
> thread about Fedora here:
> ? https://lists.isc.org/pipermail/inn-workers/2013-May/018153.html
>
> It seems that adding "-fPIE -pie" in CFLAGS could be worthwhile (because
> INN is setuid), not only for rnews.
At last, 7 years after, hardening flags (-pie and a few others) are now
set up upstream :-)
Thanks for your reminder last September!
--
Julien ?LIE
??J'adore ?tre pris en flagrant d?lire.?? (Raymond Devos)
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 128, Issue 5
*******************************************
