Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: nnrpd: adding blacklistd support (Andreas Kempe)
2. RE: nnrpd: adding blacklistd support (Julien ?LIE)
3. Re: nnrpd: adding blacklistd support (Andreas Kempe)
----------------------------------------------------------------------
Message: 1
Date: Mon, 28 Mar 2022 16:26:14 +0200
From: Andreas Kempe <[email protected]>
To: Julien ?LIE <[email protected]>
Cc: [email protected]
Subject: Re: nnrpd: adding blacklistd support
Message-ID: <YkHFhut2tg/[email protected]>
Content-Type: text/plain; charset=iso-8859-1
Hello Julien,
On Sun, Mar 27, 2022 at 11:49:15PM +0200, Julien ?LIE wrote:
> Hi Andreas,
>
> > FreeBSD ships the software blacklistd, originally from NetBSD, that
> > allows blocking brute force attacks using the firewall. I've written a
> > small patch running on Lysator's news server adding support to nnrpd
> > for automatic blocking.
> >
> > I'm writing this to probe whether there is any interest in having the
> > patch upstreamed. In its current form, the blacklist code is
> > unconditionally added but can of course be put behind an option to the
> > configure script or a FreeBSD define of some kind.
> >
> > See the attached file for the patch.
>
> Thanks for the patch. I've had a look, and it seems that the
> integration of blacklistd is pretty straight-forward.
> I think it deserves being integrated into INN, with a proper
> --with-blacklistd Autoconf probe (instead of an error if blacklistd is
> not found).
Adding it as --with-blacklistd sounds like the right thing to do, yes.
> I'll have a look. As I do not run FreeBSD myself, it would
> be great if you could somehow test it.
>
When you say that you will have a look, does that mean that you want
to rework the patch yourself?
I'm willing (and was expecting) to open a pull request on GitHub and
do testing as well as any required rewriting per your review. If you
want to do the work I'm of course willing to test any changes you make
on Lysator's server.
Cordially,
Andreas Kempe
------------------------------
Message: 2
Date: Mon, 28 Mar 2022 16:21:31 +0000
From: Julien ?LIE <[email protected]>
To: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Subject: RE: nnrpd: adding blacklistd support
Message-ID: <[email protected]>
Content-Type: text/plain; charset="iso-8859-1"
Hi Andreas,
> Adding it as --with-blacklistd sounds like the right thing to do, yes.
>
>> I'll have a look.? As I do not run FreeBSD myself, it would
>> be great if you could somehow test it.
>
> When you say that you will have a look, does that mean that you want
> to rework the patch yourself?
>
> I'm willing (and was expecting) to open a pull request on GitHub and
> do testing as well as any required rewriting per your review.
Oh, that's kind of you. It will save me time to do other work for INN
for the next major release.
Of course I don't mind your working on a pull request.
As we did not have GitHub until last year, I was accustomed to
reworking myself patches sent to our mailing-lists.
The idea would be to create a new m4/blacklistd.m4 file (based for
instance on m4/canlock.m4), add related glue in configure.ac and
Makefile.global.in, and surround the new code in nnrpd with
#if defined(HAVE_BLACKLISTD) instructions.
There is an entry in MANIFEST to add too.
Maybe a note about blacklistd in doc/pod/nnrpd.pod? (or any other
file you think more appropriate)
And mention --with-blacklistd in doc/pod/install.pod.
As GitHub continuous integration is run on Ubuntu, it cannot be
tested (so there is nothing to change in the ci directory I think).
Many thanks to you. It is greatly appreciated!
--
Julien ?LIE
------------------------------
Message: 3
Date: Mon, 28 Mar 2022 22:52:12 +0200
From: Andreas Kempe <[email protected]>
To: Julien ?LIE <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: nnrpd: adding blacklistd support
Message-ID: <YkIf/[email protected]>
Content-Type: text/plain; charset=iso-8859-1
On Mon, Mar 28, 2022 at 04:21:31PM +0000, Julien ?LIE wrote:
> Hi Andreas,
>
> > Adding it as --with-blacklistd sounds like the right thing to do, yes.
> >
> >> I'll have a look.? As I do not run FreeBSD myself, it would
> >> be great if you could somehow test it.
> >
> > When you say that you will have a look, does that mean that you want
> > to rework the patch yourself?
> >
> > I'm willing (and was expecting) to open a pull request on GitHub and
> > do testing as well as any required rewriting per your review.
>
> Oh, that's kind of you. It will save me time to do other work for INN
> for the next major release.
> Of course I don't mind your working on a pull request.
> As we did not have GitHub until last year, I was accustomed to
> reworking myself patches sent to our mailing-lists.
>
Happy to help! When I want a feature, I'm not adverse to putting in
some work to get it.
> The idea would be to create a new m4/blacklistd.m4 file (based for
> instance on m4/canlock.m4), add related glue in configure.ac and
> Makefile.global.in, and surround the new code in nnrpd with
> #if defined(HAVE_BLACKLISTD) instructions.
>
> There is an entry in MANIFEST to add too.
>
> Maybe a note about blacklistd in doc/pod/nnrpd.pod? (or any other
> file you think more appropriate)
> And mention --with-blacklistd in doc/pod/install.pod.
>
> As GitHub continuous integration is run on Ubuntu, it cannot be
> tested (so there is nothing to change in the ci directory I think).
>
>
Your suggestions sound good. I'll open a pull request on Github for
review when I have made the changes.
> Many thanks to you. It is greatly appreciated!
>
> --
> Julien ?LIE
Cordially,
Andreas Kempe
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 139, Issue 5
*******************************************
