Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: makehistory can generate duplicate lines (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Wed, 23 Nov 2022 00:15:27 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: makehistory can generate duplicate lines
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8; format=flowed
Hi Kamil,
>> But I am almost sure that this is still something wrong with
>> makehistory/cnfs code.
>> It is not understandable for me that first article during scanning spool
>> has different cycle number than others. (On fully wrapped buffer)
Ah yes, there also was that 3rd bug!
1st - duplicate entry returned by makehistory on fully wrapped cycbuff
2nd - untimely expiry of the first article of a fully wrapped cycbuff
3rd - off-by-one cycle number of the first article of a fully wrapped
cycbuff returned by makehistory
> --8<---------------cut here---------------start------------->8---
> token = CNFSMakeToken(cycbuff->name, offset, cycbuff->blksz,
> (offset > cycbuff->free) ? cycbuff->cyclenum - 1
> : cycbuff->cyclenum,
> cah.class);
> --8<---------------cut here---------------end--------------->8---
Indeed, in cnfs_next() called by makehistory, the first article has
offset == cycbuff->free, with cycle number already set to the next one.
So I believe this patch fixes that 3rd bug. I'll test it soon to make sure.
--
Julien ?LIE
??Quand j'?tais petit, je s?chais la natation.?? (Philippe Geluck)
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 145, Issue 8
*******************************************
