Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: Log file compression (Julien ?LIE)
2. Re: [PATCH 2/2] storage: Add "path" option, to store based on
the path the article went (Julien ?LIE)
----------------------------------------------------------------------
Message: 1
Date: Tue, 27 Feb 2024 22:06:12 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: Log file compression
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8; format=flowed
Hi Christoph,
> I looked for all the places that mention gzip, duplicated the
> block, and ended up with modifying [7 files].
> But this feels like going the wrong direction. The zoo of compression
> methods is huge, and next week somebody would ask for lzip or zstd.
I see your point. Yes I agree we should do better than just hard-coding
xz support.
> And from your follow-up, that innshellvars.local idea, I'd call it an
> ugly hack, and I am not that desperate to give it a try :)
:-)
> And by the way, would it hurt a lot to replace the "Z" variable name
> with something like "compress_ext"? While I'm one of those who still
> understand where that comes from - technically it's wrong, and it's
> almost 25 years since I've have last seen .Z files in the wild.
Agreed.
To not forget these points (changing the Z variable name, and adding
native support in scanlogs/news.daily for a run-time configuration of
the compression command to use), I've opened ticket #298, scheduled for
an ulterior release (INN 2.7.3). I'm currently focusing on finishing
the remaining open stuff since the last release; I hope to begin the
release process of INN 2.7.2 in March or April.
--
Julien ?LIE
??En voyant le lit vide, il le devint.?? (Ponson du Terrail)
------------------------------
Message: 2
Date: Tue, 27 Feb 2024 22:06:22 +0100
From: Julien ?LIE <[email protected]>
To: [email protected]
Subject: Re: [PATCH 2/2] storage: Add "path" option, to store based on
the path the article went
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8; format=flowed
Hi Christoph,
I've just merged your patch. Thanks again for it!
Greatly appreciated. It is a useful feature to have for the next vagues
of spam from specific sites.
> +static bool
> +MatchPath(const char *p, int len, const char *pattern)
> +{
> + char *path, *q;
> + int i, lastwhite;
> + enum uwildmat matched;
> +
> + path = xmalloc(len + 1);
> + strncpy(path, p, len);
> + path[len] = '\0';
> + for (q = path; *q; q++)
> + if (*q == '!')
> + *q = '|';
> + matched = uwildmat_poison(path, pattern);
> + free(path);
> + return matched;
> +}
FWIW, I've changed the last line to:
return (matched == UWILDMAT_MATCH);
Otherwise UWILDMAT_POISON (whose value is 2) would be considered as a
true value.
All look good otherwise.
--
Julien ?LIE
??Chuck Norris once ran cd .. in / and it worked.??
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 158, Issue 8
*******************************************
