Send inn-workers mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/inn-workers
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of inn-workers digest..."
Today's Topics:
1. Re: msync - can someone shed some light please?
(Richard Kettlewell)
----------------------------------------------------------------------
Message: 1
Date: Mon, 16 Jun 2025 17:30:00 +0100
From: Richard Kettlewell <[email protected]>
To: [email protected]
Subject: Re: msync - can someone shed some light please?
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8; format=flowed
On 15/06/2025 07:00, Julien ?LIE wrote:
> Oh, thanks for having had a look and the patch proposal.? (Thanks, Bo,
> too for the confirmation.)
>
> This function is also widely used by tradindexed, as well as some
> history writes when nfswriter is set to true in inn.conf.? So your patch
> will also fix latent bugs for these cases too.
>
> Looking at the whole source code, there's also cnfs_mapcntl, a slight
> variant of the above function in storage/cnfs/cnfs.c, which saves msync
> calls when the pages are the same as the previous ones.
> ??? start = (char *) ((uintptr_t) p & ~(size_t) (pagesize - 1));
> ??? end = (char *) (((uintptr_t) p + length + pagesize)
> ??????????????????? & ~(size_t) (pagesize - 1));
>
> end should then be fixed to use (p + length + pagesize - 1), following
> your patch proposal.
Perhaps the repeated logic should be put into a single library function
(and unit-tested)?
ttfn/rjk
------------------------------
Subject: Digest Footer
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
------------------------------
End of inn-workers Digest, Vol 166, Issue 4
*******************************************
