Vivien, We are still looking at your patch. I need to dig into what coordinate frames the various calculations are being done.
However, with a change like this where the output of a test needs to change, it is best to correct the test. This may simply require submitting a new baseline image. This is a two step process as the baseline images are maintained using a content based hashing system. The input file in the repository is just a small text file containing the md5 hash for the new image. That file needs to be updated. Then the new image needs to be uploaded to the system which serves the baseline images. I "think" this can all be done at the gerrit-push stage. Just put the updated baseline image where it needs to go and the build process and gerrit-push process should create the md5 version of the file and push the new data to the server. Here is link that describes the process http://www.itk.org/Wiki/ITK/Git/Develop/Data Jim On May 16, 2012, at 4:24 AM, Vivien Delmon wrote: > Hi, > > I pushed my first path into guerrit here: > http://review.source.kitware.com/#/c/5639/ > > Hans J. Johnson requested for a build in which a test fail which is > normal since my patch changes the geometry used by the RayCastInterpolator. > What should I do now ? correct this test to take into account the physical > coordinate system of the image and submit a change ? > > -- > Vivien Delmon > PhD student at CREATIS, Lyon > Supported by ANRT and ELEKTA > http://www.creatis.insa-lyon.fr/rio > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers Jim Miller Senior Scientist GE Research Interventional and Therapy GE imagination at work
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
