Hi Kent, Additionally, with or without "ITK_USE_SYSTEM_DCMTK", let's make sure we can pass the location of DCMTK using DCMTK_DIR.
Thanks Jc On Tue, May 29, 2012 at 11:28 AM, Bill Lorensen <[email protected]>wrote: > If you treat dcmtk as we treat vtk then you will not need a > ITK_USE_SYSTEM_DCMTK. > > On Tue, May 29, 2012 at 10:03 AM, Williams, Norman K > <[email protected]> wrote: > > Whatever we end up doing in ITK, there will be a ITK_USE_SYSTEM_DCMTK > > option. > > > > > > And yes, recent versions of DCMTK work with CLang. I logged the problems > I > > ran into in the DCMTK bug tracker. > > > > The DCMTK people are close to a new minor version release, which will > > incorporate all these changes; I believe it's coming in the next few > > weeks. That might be a good revision to standardize on going forward. > > > > On 5/25/12 5:00 PM, "Jean-Christophe Fillion-Robin" > > <[email protected]> wrote: > > > >>Hi Kent, > > >From Slicer perspective, independently of the method used to retrieve > >>DCMTK (git submodule or ExternalProject), if would be great if we could > >>configure ITKv4 passing our own version of DCMTK by specifying DCMTK_DIR. > >> > >>Within CTK, since end of April, a more recent version of DCMTK is used > >>(Snapshot 2012-02-22). See [1] And looking at the associated DCMTK change > >>log, some CLang issues have been fixed. [2] > >> > >> > >>Thanks > >>Jc > >> > >>[1] https://github.com/commontk/CTK/commit/70c0a8d > >>[2] > >> > http://git.dcmtk.org/web?p=dcmtk.git;a=blob;f=CHANGES.361;h=d281e817cbd647 > >>479dacb5e972f2d76d75602c25;hb=ae3b946f6e6231 > >> > >>On Fri, May 25, 2012 at 5:47 PM, Williams, Norman K > >><[email protected]> wrote: > >> > >>Hans has asked me to work on finishing Alexandre Gouaillard's work on the > >>DCMTK ImageIO. > >> > >>Today I've been trying to move his work from his own github repository > >>into a gerrit topic on the current branch. There are a number of issues > >>that this raises. > >> > >>1. Hans suggested using a CMake ExternalProject to build DCMTK instead of > >>what Alex did, which is to introduce the DCMTK included in the CTK > project > >>as a git module. For one thing, that version of DCMTK won't compile with > >>Clang. > >> > >>I don't see a clean way to grab and build DCMTK within the current ITK > >>framework at all. What's done everywhere else is that there's a > >>SuperBuild or MetaBuild, which builds all of a project's prerequisites as > >>ExternalProjects, and then builds the project itself as an > >>ExternalProject, configuring it with ITK_DIR, VTK_DIR etc so that it > finds > >>the prerequisites. > >> > >>Could that be something that will be part of the ITK build process? Or > are > >>we going to incorporate some sort of snapshot of DCMTK in > >>Modules/ThirdParty? > >> > >>2. DCMTK can read a DICOM directory directly, meaning that it wouldn't be > >>necessary to use an ImageSeriesReader to read dicom datasets. Should I > >>stick with creating a DCMTKSeriesFileNames? > >> > >>That feels rather clumsy, but it raises the issue of trying to choose > >>which image in a multi-series DicomDirectory to load. > >> > >>-- > >>Kent Williams [email protected] > >> > >> > >> > >> > >> > >> > >>________________________________ > >>Notice: This UI Health Care e-mail (including attachments) is covered by > >>the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is > >>confidential and may be legally privileged. If you are not the intended > >>recipient, you are hereby notified that any retention, dissemination, > >>distribution, or copying of this communication is strictly prohibited. > >>Please reply to the sender that you have received the message in error, > >>then delete it. Thank you. > >> > >> > >>________________________________ > >>_______________________________________________ > >>Powered by www.kitware.com <http://www.kitware.com> > >> > >>Visit other Kitware open-source projects at > >>http://www.kitware.com/opensource/opensource.html > >> > >>Kitware offers ITK Training Courses, for more information visit: > >>http://kitware.com/products/protraining.php > >> > >>Please keep messages on-topic and check the ITK FAQ at: > >>http://www.itk.org/Wiki/ITK_FAQ > >> > >>Follow this link to subscribe/unsubscribe: > >>http://www.itk.org/mailman/listinfo/insight-developers > >> > >> > >> > >> > >> > >> > >>-- > >>+1 919 869 8849 > >> > >> > >> > >>_______________________________________________ > >>Powered by www.kitware.com > >> > >>Visit other Kitware open-source projects at > >>http://www.kitware.com/opensource/opensource.html > >> > >>Kitware offers ITK Training Courses, for more information visit: > >>http://kitware.com/products/protraining.php > >> > >>Please keep messages on-topic and check the ITK FAQ at: > >>http://www.itk.org/Wiki/ITK_FAQ > >> > >>Follow this link to subscribe/unsubscribe: > >>http://www.itk.org/mailman/listinfo/insight-developers > > > > > > > > ________________________________ > > Notice: This UI Health Care e-mail (including attachments) is covered by > the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is > confidential and may be legally privileged. If you are not the intended > recipient, you are hereby notified that any retention, dissemination, > distribution, or copying of this communication is strictly prohibited. > Please reply to the sender that you have received the message in error, > then delete it. Thank you. > > ________________________________ > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Kitware offers ITK Training Courses, for more information visit: > > http://kitware.com/products/protraining.php > > > > Please keep messages on-topic and check the ITK FAQ at: > > http://www.itk.org/Wiki/ITK_FAQ > > > > Follow this link to subscribe/unsubscribe: > > http://www.itk.org/mailman/listinfo/insight-developers > > > > -- > Unpaid intern in BillsBasement at noware dot com > -- +1 919 869 8849
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
